From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3E8DA1FF14C for ; Fri, 15 May 2026 12:25:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E23321860A; Fri, 15 May 2026 12:25:09 +0200 (CEST) From: Hannes Laimer To: pve-devel@lists.proxmox.com Subject: [PATCH pve-network v6 4/9] sdn: fabrics: register bgp as a fabric protocol type Date: Fri, 15 May 2026 12:24:55 +0200 Message-ID: <20260515102500.216264-5-h.laimer@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260515102500.216264-1-h.laimer@proxmox.com> References: <20260515102500.216264-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778840699535 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.082 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [routemaps.pm,fabrics.pm] Message-ID-Hash: OIIZQEYA52VNEFE2L62IYKP5OHCAN2I5 X-Message-ID-Hash: OIIZQEYA52VNEFE2L62IYKP5OHCAN2I5 X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Add 'bgp' to the pve-sdn-fabric-protocol enum so it can be selected when creating or updating fabric configurations via the API. Signed-off-by: Hannes Laimer --- src/PVE/Network/SDN/Fabrics.pm | 63 +++++++++++++++++++++++++++++++- src/PVE/Network/SDN/RouteMaps.pm | 15 ++++++++ 2 files changed, 77 insertions(+), 1 deletion(-) diff --git a/src/PVE/Network/SDN/Fabrics.pm b/src/PVE/Network/SDN/Fabrics.pm index fa76367..7e5f09b 100644 --- a/src/PVE/Network/SDN/Fabrics.pm +++ b/src/PVE/Network/SDN/Fabrics.pm @@ -51,7 +51,7 @@ PVE::JSONSchema::register_standard_option( { description => "Type of configuration entry in an SDN Fabric section config", type => 'string', - enum => ['openfabric', 'ospf', 'wireguard'], + enum => ['openfabric', 'ospf', 'wireguard', 'bgp'], }, ); @@ -263,6 +263,21 @@ sub node_properties { description => 'List of WireGuard network interfaces for this node.', optional => 1, }, + { + 'instance-types' => ['bgp'], + items => { + type => 'string', + format => { + name => { + type => 'string', + format => 'pve-iface', + description => 'Name of the network interface', + }, + }, + }, + description => 'BGP network interface', + optional => 1, + }, ], }, public_key => { @@ -350,6 +365,15 @@ sub node_properties { type => 'array', 'type-property' => 'protocol', oneOf => [ + { + type => 'array', + 'instance-types' => ['bgp'], + items => { + type => 'string', + enum => ['interfaces', 'ip', 'ip6'], + }, + optional => 1, + }, { type => 'array', 'instance-types' => ['openfabric', 'ospf'], @@ -478,6 +502,34 @@ sub fabric_properties { }, optional => 1, }, + { + type => 'array', + 'instance-types' => ['bgp'], + items => { + type => 'string', + format => { + source => { + type => 'string', + description => + 'The protocol from which to redistribute routes from.', + enum => [ + 'connected', + 'kernel', + 'ospf', + 'static', + ], + }, + 'route-map' => { + type => 'string', + format => 'pve-sdn-route-map-id', + description => + 'Route map to filter or transform redistributed routes from this source.', + optional => 1, + }, + }, + }, + optional => 1, + }, ], }, }; @@ -497,6 +549,15 @@ sub fabric_properties { }, optional => 1, }, + { + type => 'array', + 'instance-types' => ['bgp'], + items => { + type => 'string', + enum => ['redistribute', 'route_filter', 'route_map_in', 'route_map_out'], + }, + optional => 1, + }, { type => 'array', 'instance-types' => ['ospf'], diff --git a/src/PVE/Network/SDN/RouteMaps.pm b/src/PVE/Network/SDN/RouteMaps.pm index c02a38f..71fa0e7 100644 --- a/src/PVE/Network/SDN/RouteMaps.pm +++ b/src/PVE/Network/SDN/RouteMaps.pm @@ -126,6 +126,21 @@ sub check_references { if $controller->{'route-map-out'} eq $route_map_id; } } + + my $fabrics = PVE::Network::SDN::Fabrics::config()->list_fabrics(); + for my $fabric_id (keys $fabrics->%*) { + my $fabric = $fabrics->{$fabric_id}; + + if ($fabric->{route_map_in}) { + die "route map $route_map_id still referenced by fabric $fabric_id" + if $fabric->{route_map_in} eq $route_map_id; + } + + if ($fabric->{route_map_out}) { + die "route map $route_map_id still referenced by fabric $fabric_id" + if $fabric->{route_map_out} eq $route_map_id; + } + } } sub route_map_properties { -- 2.47.3