public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server 4/4] api: human monitor: warn about deprecated commands
Date: Tue, 12 May 2026 14:09:51 +0200	[thread overview]
Message-ID: <20260512120959.169149-5-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260512120959.169149-1-f.ebner@proxmox.com>

The 'stopcapture' and 'wavcapture' HMP commands are deprecated since
QEMU 10.2.

Reference:
https://qemu-project.gitlab.io/qemu/about/deprecated.html#human-machine-protocol-hmp-commands

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/API2/Qemu.pm          | 4 ++++
 src/PVE/API2/Qemu/HMPPerms.pm | 2 ++
 2 files changed, 6 insertions(+)

diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
index d762401b..7f042f98 100644
--- a/src/PVE/API2/Qemu.pm
+++ b/src/PVE/API2/Qemu.pm
@@ -5841,6 +5841,10 @@ __PACKAGE__->register_method({
             die "unexpected required permission '$required_perm' for command '$command_name'\n";
         }
 
+        if ($command_name eq 'stopcapture' || $command_name eq 'wavcapture') {
+            warn "command '$command_name' is deprecated and will be dropped in a future release\n";
+        }
+
         my $vmid = $param->{vmid};
 
         my $conf = PVE::QemuConfig->load_config($vmid); # check if VM exists
diff --git a/src/PVE/API2/Qemu/HMPPerms.pm b/src/PVE/API2/Qemu/HMPPerms.pm
index 5d5609d4..4763ca15 100644
--- a/src/PVE/API2/Qemu/HMPPerms.pm
+++ b/src/PVE/API2/Qemu/HMPPerms.pm
@@ -205,6 +205,8 @@ sub generate_description() {
 
     $text .= "The following commands are root-only: " . join(', ', $root_only_cmds->@*) . "\n";
 
+    $text .= "\nThe following commands are deprecated: stopcapture, wavcapture\n";
+
     return $text;
 }
 
-- 
2.47.3





      parent reply	other threads:[~2026-05-12 12:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 12:09 [PATCH-SERIES qemu-server 0/4] adapt to deprecated and removed features for QEMU 11 Fiona Ebner
2026-05-12 12:09 ` [PATCH qemu-server 1/4] cfg2cmd: avoid using deprecated 'debug-threads' option with QEMU binary >= 11.0 Fiona Ebner
2026-05-12 12:09 ` [PATCH qemu-server 2/4] api: hmp permissions: use v5.36 for module Fiona Ebner
2026-05-12 12:09 ` [PATCH qemu-server 3/4] api: hmp permissions: make return explicit Fiona Ebner
2026-05-12 12:09 ` Fiona Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260512120959.169149-5-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal