From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 802A41FF146 for ; Tue, 12 May 2026 14:11:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DA55811AD1; Tue, 12 May 2026 14:10:44 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 4/4] api: human monitor: warn about deprecated commands Date: Tue, 12 May 2026 14:09:51 +0200 Message-ID: <20260512120959.169149-5-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260512120959.169149-1-f.ebner@proxmox.com> References: <20260512120959.169149-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778587690876 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7KL4KWJKWUO2RPFNAFDDWITMIHZUO6QL X-Message-ID-Hash: 7KL4KWJKWUO2RPFNAFDDWITMIHZUO6QL X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The 'stopcapture' and 'wavcapture' HMP commands are deprecated since QEMU 10.2. Reference: https://qemu-project.gitlab.io/qemu/about/deprecated.html#human-machine-protocol-hmp-commands Signed-off-by: Fiona Ebner --- src/PVE/API2/Qemu.pm | 4 ++++ src/PVE/API2/Qemu/HMPPerms.pm | 2 ++ 2 files changed, 6 insertions(+) diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm index d762401b..7f042f98 100644 --- a/src/PVE/API2/Qemu.pm +++ b/src/PVE/API2/Qemu.pm @@ -5841,6 +5841,10 @@ __PACKAGE__->register_method({ die "unexpected required permission '$required_perm' for command '$command_name'\n"; } + if ($command_name eq 'stopcapture' || $command_name eq 'wavcapture') { + warn "command '$command_name' is deprecated and will be dropped in a future release\n"; + } + my $vmid = $param->{vmid}; my $conf = PVE::QemuConfig->load_config($vmid); # check if VM exists diff --git a/src/PVE/API2/Qemu/HMPPerms.pm b/src/PVE/API2/Qemu/HMPPerms.pm index 5d5609d4..4763ca15 100644 --- a/src/PVE/API2/Qemu/HMPPerms.pm +++ b/src/PVE/API2/Qemu/HMPPerms.pm @@ -205,6 +205,8 @@ sub generate_description() { $text .= "The following commands are root-only: " . join(', ', $root_only_cmds->@*) . "\n"; + $text .= "\nThe following commands are deprecated: stopcapture, wavcapture\n"; + return $text; } -- 2.47.3