* [PATCH manager] pvebanner: fix URL IPv6 address formatting
@ 2026-05-11 9:35 Gabriel Goller
2026-05-12 2:09 ` applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Gabriel Goller @ 2026-05-11 9:35 UTC (permalink / raw)
To: pve-devel
Wrap IPv6 local IP address in brackets when generating the web UI
URL. Otherwise browsers (firefox and chromium tested) can't tell the
difference between port and ipv6 address segment.
Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
bin/pvebanner | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/bin/pvebanner b/bin/pvebanner
index 7e8526101adf..6a214f74c04a 100755
--- a/bin/pvebanner
+++ b/bin/pvebanner
@@ -12,6 +12,8 @@ my $xline = '-' x 78;
my $banner = '';
if ($localip) {
+ my $urlip = $localip =~ m/:/ ? "[$localip]" : $localip;
+
$banner .= <<__EOBANNER;
$xline
@@ -19,7 +21,7 @@ $xline
Welcome to the Proxmox Virtual Environment. Please use your web browser to
configure this server - connect to:
- https://${localip}:8006/
+ https://${urlip}:8006/
$xline
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* applied: [PATCH manager] pvebanner: fix URL IPv6 address formatting
2026-05-11 9:35 [PATCH manager] pvebanner: fix URL IPv6 address formatting Gabriel Goller
@ 2026-05-12 2:09 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2026-05-12 2:09 UTC (permalink / raw)
To: pve-devel, Gabriel Goller
On Mon, 11 May 2026 11:35:52 +0200, Gabriel Goller wrote:
> Wrap IPv6 local IP address in brackets when generating the web UI
> URL. Otherwise browsers (firefox and chromium tested) can't tell the
> difference between port and ipv6 address segment.
Applied, thanks!
[1/1] pvebanner: fix URL IPv6 address formatting
commit: e83bbd83d9829cc5209001baaaa62203887116ed
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-12 2:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-11 9:35 [PATCH manager] pvebanner: fix URL IPv6 address formatting Gabriel Goller
2026-05-12 2:09 ` applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox