From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager v3 16/17] ui: cpu flags selector: add search bar for large lists of flags
Date: Thu, 30 Apr 2026 17:35:04 +0200 [thread overview]
Message-ID: <20260430153505.527032-17-a.bied-charreton@proxmox.com> (raw)
In-Reply-To: <20260430153505.527032-1-a.bied-charreton@proxmox.com>
Add a search bar for the CPU flags list queried from
/cluster/qemu/cpu-flags, which is very long.
Do not display it for VM-specific flags (~15 flags), as they are
easier to scan through, and it would overload the ProcessorEdit window.
Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
www/manager6/form/VMCPUFlagSelector.js | 128 ++++++++++++++++---------
1 file changed, 83 insertions(+), 45 deletions(-)
diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js
index ef9555e6..6c9437b7 100644
--- a/www/manager6/form/VMCPUFlagSelector.js
+++ b/www/manager6/form/VMCPUFlagSelector.js
@@ -70,7 +70,11 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
let flags = '';
- store.getData().each(function (rec) {
+ // Get the values directly from the data source. Using store.getData() here
+ // would iterate over the filtered values, potentially overwriting flags that
+ // are set but currently filtered out by the search bar.
+ let source = store.getDataSource();
+ source.each(function (rec) {
let s = rec.get('state');
if (s && s !== '=') {
let f = rec.get('name');
@@ -300,57 +304,91 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
me.value = me.originalValue = '';
- me.dockedItems = [
+ let topToolbarItems = [
{
- xtype: 'toolbar',
- dock: 'top',
- hidden: false,
+ xtype: 'tbtext',
+ text: gettext('Acceleration:'),
+ autoEl: {
+ tag: 'span',
+ 'data-qtip': gettext(
+ "A custom CPU model using acceleration-specific flags can only be assigned to VMs configured with the matching acceleration type, i.e., 'kvm: 1' for KVM, or 'kvm: 0' for TCG.",
+ ),
+ },
+ },
+ {
+ xtype: 'radiogroup',
+ layout: 'hbox',
+ validateOnChange: false,
items: [
{
- xtype: 'tbtext',
- text: gettext('Acceleration:'),
- autoEl: {
- tag: 'span',
- 'data-qtip': gettext(
- 'A custom CPU model using acceleration-specific flags can only be assigned to VMs configured with the matching acceleration type, i.e., "kvm: 1" for KVM, or "kvm: 0" for TCG.',
- ),
- },
+ boxLabel: 'KVM',
+ inputValue: 'kvm',
+ name: 'accel',
+ checked: true,
+ isFormField: false,
},
{
- xtype: 'radiogroup',
- layout: 'hbox',
- validateOnChange: false,
- items: [
- {
- boxLabel: 'KVM',
- inputValue: 'kvm',
- name: 'accel',
- checked: true,
- isFormField: false,
- },
- {
- boxLabel: 'TCG',
- inputValue: 'tcg',
- name: 'accel',
- margin: '0 0 0 10',
- isFormField: false,
- },
- ],
- listeners: {
- change: function (_, value) {
- let view = this.up('grid');
- let proxy = view.getStore().getProxy();
- let accel = value.accel;
- if (accel) {
- proxy.setExtraParam('accel', accel);
- } else {
- delete proxy.extraParams.accel;
- }
- view.getStore().load();
- },
- },
+ boxLabel: 'TCG',
+ inputValue: 'tcg',
+ name: 'accel',
+ margin: '0 0 0 10',
+ isFormField: false,
},
],
+ listeners: {
+ change: function (_, value) {
+ let view = this.up('grid');
+ let proxy = view.getStore().getProxy();
+ let accel = value.accel;
+ if (accel) {
+ proxy.setExtraParam('accel', accel);
+ } else {
+ delete proxy.extraParams.accel;
+ }
+ view.getStore().load();
+ },
+ },
+ },
+ ];
+
+ if (!me.restrictToVMFlags) {
+ topToolbarItems.push('-', {
+ xtype: 'textfield',
+ emptyText: gettext('Search...'),
+ submitValue: false,
+ listeners: {
+ change: {
+ buffer: 100,
+ fn: function (field, value) {
+ let store = field.up('grid').getStore();
+ if (value) {
+ let lv = value.toLowerCase();
+ store.addFilter({
+ id: 'search-filter',
+ filterFn: (rec) => {
+ let name = rec.get('name') || '';
+ let desc = rec.get('description') || '';
+ return (
+ name.toLowerCase().includes(lv) ||
+ desc.toLowerCase().includes(lv)
+ );
+ },
+ });
+ } else {
+ store.removeFilter('search-filter');
+ }
+ },
+ },
+ },
+ });
+ }
+
+ me.dockedItems = [
+ {
+ xtype: 'toolbar',
+ dock: 'top',
+ hidden: false,
+ items: topToolbarItems,
},
];
--
2.47.3
next prev parent reply other threads:[~2026-04-30 15:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 15:34 [PATCH docs/manager/qemu-server v3 00/17] Add API and UI for custom CPU models Arthur Bied-Charreton
2026-04-30 15:34 ` [PATCH pve-docs v3 01/17] qm: add anchor to "CPU Type" section Arthur Bied-Charreton
2026-04-30 15:34 ` [PATCH qemu-server v3 02/17] cpu config: rename CPU models config path variable Arthur Bied-Charreton
2026-04-30 15:34 ` [PATCH qemu-server v3 03/17] cpu flags: move cpu flags-related utilities to their own module Arthur Bied-Charreton
2026-04-30 15:34 ` [PATCH qemu-server v3 04/17] cpu flags: add helper querying CPU flags with nodes supporting them Arthur Bied-Charreton
2026-04-30 15:34 ` [PATCH qemu-server v3 05/17] cpu config: add helpers to lock and write config Arthur Bied-Charreton
2026-04-30 15:34 ` [PATCH qemu-server v3 06/17] cpu: register standard option for CPU format Arthur Bied-Charreton
2026-04-30 15:34 ` [PATCH qemu-server v3 07/17] cpu config: set 'type' field before writing Arthur Bied-Charreton
2026-04-30 15:34 ` [PATCH qemu-server v3 08/17] cpu flags: improve flags list returned by endpoint Arthur Bied-Charreton
2026-04-30 15:34 ` [PATCH pve-manager v3 09/17] api: add endpoint querying available CPU flags cluster-wide Arthur Bied-Charreton
2026-04-30 15:34 ` [PATCH pve-manager v3 10/17] api: add CRUD handlers for custom CPU models Arthur Bied-Charreton
2026-04-30 15:34 ` [PATCH pve-manager v3 11/17] ui: cpu model selector: allow filtering out custom models Arthur Bied-Charreton
2026-04-30 15:35 ` [PATCH pve-manager v3 12/17] ui: add basic custom CPU model editor Arthur Bied-Charreton
2026-04-30 15:35 ` [PATCH pve-manager v3 13/17] ui: cpu flags selector: add CPU flag editor for custom models Arthur Bied-Charreton
2026-04-30 15:35 ` [PATCH pve-manager v3 14/17] ui: cpu flags selector: fix buffered rendering error Arthur Bied-Charreton
2026-04-30 15:35 ` [PATCH pve-manager v3 15/17] ui: cpu flags selector: allow filtering out flags supported on 0 nodes Arthur Bied-Charreton
2026-04-30 15:35 ` Arthur Bied-Charreton [this message]
2026-04-30 15:35 ` [PATCH pve-manager v3 17/17] RFC: ui: group custom CPU with resource mappings Arthur Bied-Charreton
2026-04-30 16:03 ` supersed: [PATCH docs/manager/qemu-server v3 00/17] Add API and UI for custom CPU models Arthur Bied-Charreton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260430153505.527032-17-a.bied-charreton@proxmox.com \
--to=a.bied-charreton@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox