public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager v3 11/17] ui: cpu model selector: allow filtering out custom models
Date: Thu, 30 Apr 2026 17:34:59 +0200	[thread overview]
Message-ID: <20260430153505.527032-12-a.bied-charreton@proxmox.com> (raw)
In-Reply-To: <20260430153505.527032-1-a.bied-charreton@proxmox.com>

Add 'showCustomModels' configuration parameter. When set to false, only
default CPU models will be shown.

This is needed when using the CPUModelSelector in the context of
creating a new custom CPU model, where we do not want to allow the
reported-model being another custom CPU model.

Based on patch by Stefan Reiter, with allowCustom renamed to
showCustomModels:
https://lore.proxmox.com/pve-devel/20211028114150.3245864-8-s.reiter@proxmox.com/

Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
 www/manager6/form/CPUModelSelector.js | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/www/manager6/form/CPUModelSelector.js b/www/manager6/form/CPUModelSelector.js
index a55d473e..a718d2ed 100644
--- a/www/manager6/form/CPUModelSelector.js
+++ b/www/manager6/form/CPUModelSelector.js
@@ -19,6 +19,9 @@ Ext.define('PVE.form.CPUModelSelector', {
     autoSelect: false,
 
     deleteEmpty: true,
+    config: {
+        showCustomModels: true,
+    },
 
     getSubmitData: function () {
         let me = this,
@@ -135,4 +138,11 @@ Ext.define('PVE.form.CPUModelSelector', {
             },
         },
     },
+    initComponent: function () {
+        let me = this;
+        me.callParent();
+        if (!me.showCustomModels) {
+            me.getStore().addFilter({ filterFn: (rec) => !rec.data.custom });
+        }
+    },
 });
-- 
2.47.3




  parent reply	other threads:[~2026-04-30 15:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-30 15:34 [PATCH docs/manager/qemu-server v3 00/17] Add API and UI for custom CPU models Arthur Bied-Charreton
2026-04-30 15:34 ` [PATCH pve-docs v3 01/17] qm: add anchor to "CPU Type" section Arthur Bied-Charreton
2026-04-30 15:34 ` [PATCH qemu-server v3 02/17] cpu config: rename CPU models config path variable Arthur Bied-Charreton
2026-04-30 15:34 ` [PATCH qemu-server v3 03/17] cpu flags: move cpu flags-related utilities to their own module Arthur Bied-Charreton
2026-04-30 15:34 ` [PATCH qemu-server v3 04/17] cpu flags: add helper querying CPU flags with nodes supporting them Arthur Bied-Charreton
2026-04-30 15:34 ` [PATCH qemu-server v3 05/17] cpu config: add helpers to lock and write config Arthur Bied-Charreton
2026-04-30 15:34 ` [PATCH qemu-server v3 06/17] cpu: register standard option for CPU format Arthur Bied-Charreton
2026-04-30 15:34 ` [PATCH qemu-server v3 07/17] cpu config: set 'type' field before writing Arthur Bied-Charreton
2026-04-30 15:34 ` [PATCH qemu-server v3 08/17] cpu flags: improve flags list returned by endpoint Arthur Bied-Charreton
2026-04-30 15:34 ` [PATCH pve-manager v3 09/17] api: add endpoint querying available CPU flags cluster-wide Arthur Bied-Charreton
2026-04-30 15:34 ` [PATCH pve-manager v3 10/17] api: add CRUD handlers for custom CPU models Arthur Bied-Charreton
2026-04-30 15:34 ` Arthur Bied-Charreton [this message]
2026-04-30 15:35 ` [PATCH pve-manager v3 12/17] ui: add basic custom CPU model editor Arthur Bied-Charreton
2026-04-30 15:35 ` [PATCH pve-manager v3 13/17] ui: cpu flags selector: add CPU flag editor for custom models Arthur Bied-Charreton
2026-04-30 15:35 ` [PATCH pve-manager v3 14/17] ui: cpu flags selector: fix buffered rendering error Arthur Bied-Charreton
2026-04-30 15:35 ` [PATCH pve-manager v3 15/17] ui: cpu flags selector: allow filtering out flags supported on 0 nodes Arthur Bied-Charreton
2026-04-30 15:35 ` [PATCH pve-manager v3 16/17] ui: cpu flags selector: add search bar for large lists of flags Arthur Bied-Charreton
2026-04-30 15:35 ` [PATCH pve-manager v3 17/17] RFC: ui: group custom CPU with resource mappings Arthur Bied-Charreton
2026-04-30 16:03 ` supersed: [PATCH docs/manager/qemu-server v3 00/17] Add API and UI for custom CPU models Arthur Bied-Charreton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260430153505.527032-12-a.bied-charreton@proxmox.com \
    --to=a.bied-charreton@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal