public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Michael Köppl" <m.koeppl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH docs v3 1/8] asciidoc-pve: allow linking sections with get_help_link
Date: Mon, 27 Apr 2026 19:05:41 +0200	[thread overview]
Message-ID: <20260427170548.307698-2-m.koeppl@proxmox.com> (raw)
In-Reply-To: <20260427170548.307698-1-m.koeppl@proxmox.com>

scan_extjs_file only scanned for occurrences of onlineHelp. Linking to
specific sections of the documentation with get_help_link was not
possible withouth an accompanying onlineHelp entry. Therefore, also scan
for occurrences of get_help_link.

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
I'm sure this can be done more elegantly, but I wanted to avoid breaking
the existing regex for onlineHelp. Perhaps someone more knowledgeable in
regexes can point me in the right direction.

 scripts/asciidoc-pve.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/asciidoc-pve.in b/scripts/asciidoc-pve.in
index d42ddbe9..c4e72635 100644
--- a/scripts/asciidoc-pve.in
+++ b/scripts/asciidoc-pve.in
@@ -464,7 +464,7 @@ sub scan_extjs_file {
     debug("scan-extjs $filename");
 
     while (defined(my $line = <$fh>)) {
-        if ($line =~ m/\s+onlineHelp:\s*[\'\"]([^{}\[\]\'\"]+)[\'\"]/) {
+        if ($line =~ m/(?|\s+onlineHelp:\s*[\'\"]([^{}\[\]\'\"]+)[\'\"]|\bget_help_link\(\s*[\'\"]([^{}\[\]\'\"]+)[\'\"]\s*\))/) {
             my $blockid = $1;
             my $link = $fileinfo->{blockid_target}->{default}->{$blockid};
             if (!(defined($link) || defined($online_help_links->{$blockid}))) {
-- 
2.47.3





  reply	other threads:[~2026-04-27 17:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 17:05 [PATCH cluster/docs/manager v3 0/8] add warning messages for high token timeouts in clusters Michael Köppl
2026-04-27 17:05 ` Michael Köppl [this message]
2026-04-27 17:05 ` [PATCH docs v3 2/8] pvecm: add explicit anchor for token coefficient section Michael Köppl
2026-04-27 17:05 ` [PATCH docs v3 3/8] pvecm: add info about warnings regarding token coefficient Michael Köppl
2026-04-27 17:05 ` [PATCH cluster v3 4/8] add functions to determine warning level for high token timeouts Michael Köppl
2026-04-27 17:05 ` [PATCH cluster v3 5/8] pvecm: warn users of high token timeouts when using status command Michael Köppl
2026-04-27 17:05 ` [PATCH cluster v3 6/8] api: add token timeout and warning level to cluster join info Michael Köppl
2026-04-27 17:05 ` [PATCH manager v3 7/8] ui: cluster info: move initialization of items to initComponent Michael Köppl
2026-04-27 17:05 ` [PATCH manager v3 8/8] ui: cluster info: warn users of high token timeout in join info Michael Köppl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260427170548.307698-2-m.koeppl@proxmox.com \
    --to=m.koeppl@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal