From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 88F1F1FF133 for ; Mon, 27 Apr 2026 19:06:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9A19D24383; Mon, 27 Apr 2026 19:05:57 +0200 (CEST) From: =?UTF-8?q?Michael=20K=C3=B6ppl?= To: pve-devel@lists.proxmox.com Subject: [PATCH docs v3 1/8] asciidoc-pve: allow linking sections with get_help_link Date: Mon, 27 Apr 2026 19:05:41 +0200 Message-ID: <20260427170548.307698-2-m.koeppl@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260427170548.307698-1-m.koeppl@proxmox.com> References: <20260427170548.307698-1-m.koeppl@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777309455137 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.097 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZB2UMP6GGUACVOVKPX3QO5UUJUD5YQPT X-Message-ID-Hash: ZB2UMP6GGUACVOVKPX3QO5UUJUD5YQPT X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: scan_extjs_file only scanned for occurrences of onlineHelp. Linking to specific sections of the documentation with get_help_link was not possible withouth an accompanying onlineHelp entry. Therefore, also scan for occurrences of get_help_link. Signed-off-by: Michael Köppl --- I'm sure this can be done more elegantly, but I wanted to avoid breaking the existing regex for onlineHelp. Perhaps someone more knowledgeable in regexes can point me in the right direction. scripts/asciidoc-pve.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/asciidoc-pve.in b/scripts/asciidoc-pve.in index d42ddbe9..c4e72635 100644 --- a/scripts/asciidoc-pve.in +++ b/scripts/asciidoc-pve.in @@ -464,7 +464,7 @@ sub scan_extjs_file { debug("scan-extjs $filename"); while (defined(my $line = <$fh>)) { - if ($line =~ m/\s+onlineHelp:\s*[\'\"]([^{}\[\]\'\"]+)[\'\"]/) { + if ($line =~ m/(?|\s+onlineHelp:\s*[\'\"]([^{}\[\]\'\"]+)[\'\"]|\bget_help_link\(\s*[\'\"]([^{}\[\]\'\"]+)[\'\"]\s*\))/) { my $blockid = $1; my $link = $fileinfo->{blockid_target}->{default}->{$blockid}; if (!(defined($link) || defined($online_help_links->{$blockid}))) { -- 2.47.3