From: "Max R. Carrara" <m.carrara@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-storage v2 2/3] plugin: remove needless inequality check when creating content subdirs
Date: Thu, 23 Apr 2026 11:46:15 +0200 [thread overview]
Message-ID: <20260423094619.205988-3-m.carrara@proxmox.com> (raw)
In-Reply-To: <20260423094619.205988-1-m.carrara@proxmox.com>
`$subdir` is a subdirectory of `$path`, so the variables are never
equal. Even if they were equal for some reason, calling `mkpath()`
here wouldn't fail or be otherwise dangerous.
To elaborate, note that even if the user happened to configure an
empty path for a given content subdirectory, `get_subdir()` would
still return "$path/", which is obviously not equal to `$path`.
However, third-party plugins which have overridden `get_subdir()`
might actually return "$path", in which case the inequality check
indeed passes. Nevertheless, calling `mkpath()` remains harmless,
since it will at most create the `$path` dir for the given storage.
Therefore, remove this check.
Signed-off-by: Max R. Carrara <m.carrara@proxmox.com>
---
src/PVE/Storage/Plugin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
index a7c5d083..04d87842 100644
--- a/src/PVE/Storage/Plugin.pm
+++ b/src/PVE/Storage/Plugin.pm
@@ -1919,7 +1919,7 @@ sub activate_storage {
|| ($vtype eq 'backup' && defined($scfg->{content}->{'rootdir'}))
) {
my $subdir = $class->get_subdir($scfg, $vtype);
- mkpath $subdir if $subdir ne $path;
+ mkpath $subdir;
}
}
}
--
2.47.3
next prev parent reply other threads:[~2026-04-23 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 9:46 [PATCH pve-storage v2 0/3] Improve mkpath Error Message in activate_storage Max R. Carrara
2026-04-23 9:46 ` [PATCH pve-storage v2 1/3] plugin: use guard clause to reduce nesting Max R. Carrara
2026-04-23 9:46 ` Max R. Carrara [this message]
2026-04-23 9:46 ` [PATCH pve-storage v2 3/3] plugin: improve error handling when creating a content subdir fails Max R. Carrara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260423094619.205988-3-m.carrara@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox