From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2F4D51FF13F for ; Thu, 23 Apr 2026 11:47:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 59DC1108AA; Thu, 23 Apr 2026 11:46:57 +0200 (CEST) From: "Max R. Carrara" To: pve-devel@lists.proxmox.com Subject: [PATCH pve-storage v2 2/3] plugin: remove needless inequality check when creating content subdirs Date: Thu, 23 Apr 2026 11:46:15 +0200 Message-ID: <20260423094619.205988-3-m.carrara@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260423094619.205988-1-m.carrara@proxmox.com> References: <20260423094619.205988-1-m.carrara@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776937494770 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.082 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JFFK5PST6H46OO6ACGB45KYIRAGJ33GP X-Message-ID-Hash: JFFK5PST6H46OO6ACGB45KYIRAGJ33GP X-MailFrom: m.carrara@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: `$subdir` is a subdirectory of `$path`, so the variables are never equal. Even if they were equal for some reason, calling `mkpath()` here wouldn't fail or be otherwise dangerous. To elaborate, note that even if the user happened to configure an empty path for a given content subdirectory, `get_subdir()` would still return "$path/", which is obviously not equal to `$path`. However, third-party plugins which have overridden `get_subdir()` might actually return "$path", in which case the inequality check indeed passes. Nevertheless, calling `mkpath()` remains harmless, since it will at most create the `$path` dir for the given storage. Therefore, remove this check. Signed-off-by: Max R. Carrara --- src/PVE/Storage/Plugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index a7c5d083..04d87842 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -1919,7 +1919,7 @@ sub activate_storage { || ($vtype eq 'backup' && defined($scfg->{content}->{'rootdir'})) ) { my $subdir = $class->get_subdir($scfg, $vtype); - mkpath $subdir if $subdir ne $path; + mkpath $subdir; } } } -- 2.47.3