public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Shannon Sterz <s.sterz@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager v4 3/3] fix #5076: ui: dc: add an optional "audiences" field for open id realms
Date: Mon, 20 Apr 2026 17:33:32 +0200	[thread overview]
Message-ID: <20260420153332.414620-4-s.sterz@proxmox.com> (raw)
In-Reply-To: <20260420153332.414620-1-s.sterz@proxmox.com>

allows users to configure additional open id audiences that may be
provided by the open id realm.

Originally-by: Alexander Abraham <a.abraham@proxmox.com>
[SS:
 * removed unnecessary helper functions
 * moved code for formatting audiences to AuthEditOpenId from
   AuthEditBase, as only open id realms set this property
 * rephrased commit message for clarity
]

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 www/manager6/dc/AuthEditOpenId.js | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/www/manager6/dc/AuthEditOpenId.js b/www/manager6/dc/AuthEditOpenId.js
index dc6c22e61..878fb267d 100644
--- a/www/manager6/dc/AuthEditOpenId.js
+++ b/www/manager6/dc/AuthEditOpenId.js
@@ -13,6 +13,10 @@ Ext.define('PVE.panel.OpenIDInputPanel', {
             delete values.verify;
         }
 
+        if (values.audiences) {
+            values.audiences = values.audiences.split(" ");
+        }
+
         return me.callParent([values]);
     },
 
@@ -149,6 +153,15 @@ Ext.define('PVE.panel.OpenIDInputPanel', {
                 deleteEmpty: '{!isCreate}',
             },
         },
+        {
+            xtype: 'proxmoxtextfield',
+            name: 'audiences',
+            fieldLabel: gettext('Audiences'),
+            submitEmpty: false,
+            cbind: {
+                deleteEmpty: '{!isCreate}',
+            },
+        },
     ],
 
     initComponent: function () {
-- 
2.47.3





  parent reply	other threads:[~2026-04-20 15:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 15:33 [PATCH access-control/manager/proxmox v4 0/3] fix #5076: add support for open id audiences Shannon Sterz
2026-04-20 15:33 ` [PATCH proxmox v4 1/3] fix #5076: openid: add logic to handle OIDC audiences Shannon Sterz
2026-04-20 15:33 ` [PATCH access-control v4 2/3] fix #5076: auth: open id: add an optional "audiences" field Shannon Sterz
2026-04-20 15:33 ` Shannon Sterz [this message]
2026-04-21 10:25 ` [PATCH access-control/manager/proxmox v4 0/3] fix #5076: add support for open id audiences Shannon Sterz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260420153332.414620-4-s.sterz@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal