From: Shannon Sterz <s.sterz@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH access-control v4 2/3] fix #5076: auth: open id: add an optional "audiences" field
Date: Mon, 20 Apr 2026 17:33:31 +0200 [thread overview]
Message-ID: <20260420153332.414620-3-s.sterz@proxmox.com> (raw)
In-Reply-To: <20260420153332.414620-1-s.sterz@proxmox.com>
adds an optional "audiences" field to the open id configuration
schema. "audiences" is a list of additionally accepted audiences that
an open id provider may include.
Originally-by: Alexander Abraham <a.abraham@proxmox.com>
[SS:
* rephrased the commit message for style and clarity
* adjusted the parameter description to be clearer
* removed a validation pattern that was incorrect and set a
maxLength for members of the "audiences" array
* removed changes that only reformatted unrelated code
]
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
src/PVE/API2/OpenId.pm | 4 ++++
src/PVE/Auth/OpenId.pm | 12 ++++++++++++
2 files changed, 16 insertions(+)
diff --git a/src/PVE/API2/OpenId.pm b/src/PVE/API2/OpenId.pm
index cccd615..58ffd81 100644
--- a/src/PVE/API2/OpenId.pm
+++ b/src/PVE/API2/OpenId.pm
@@ -46,6 +46,10 @@ my $lookup_openid_auth = sub {
$openid_config->{acr_values} = [PVE::Tools::split_list($acr)];
}
+ if (defined(my $audiences = $config->{'audiences'})) {
+ $openid_config->{audiences} = $config->{'audiences'};
+ }
+
my $openid = PVE::RS::OpenId->discover($openid_config, $redirect_url);
return ($config, $openid);
};
diff --git a/src/PVE/Auth/OpenId.pm b/src/PVE/Auth/OpenId.pm
index 2209040..2467263 100755
--- a/src/PVE/Auth/OpenId.pm
+++ b/src/PVE/Auth/OpenId.pm
@@ -92,6 +92,17 @@ sub properties {
default => 1,
optional => 1,
},
+ 'audiences' => {
+ description =>
+ "A list of audiences that the OpenID Issuer may include that are accepted in "
+ . "addition to 'client-id'.",
+ type => 'array',
+ 'items' => {
+ type => 'string',
+ optional => 1,
+ maxLength => 256,
+ },
+ },
};
}
@@ -108,6 +119,7 @@ sub options {
prompt => { optional => 1 },
scopes => { optional => 1 },
"acr-values" => { optional => 1 },
+ audiences => { optional => 1 },
default => { optional => 1 },
comment => { optional => 1 },
"query-userinfo" => { optional => 1 },
--
2.47.3
next prev parent reply other threads:[~2026-04-20 15:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 15:33 [PATCH access-control/manager/proxmox v4 0/3] fix #5076: add support for open id audiences Shannon Sterz
2026-04-20 15:33 ` [PATCH proxmox v4 1/3] fix #5076: openid: add logic to handle OIDC audiences Shannon Sterz
2026-04-20 15:33 ` Shannon Sterz [this message]
2026-04-20 15:33 ` [PATCH manager v4 3/3] fix #5076: ui: dc: add an optional "audiences" field for open id realms Shannon Sterz
2026-04-21 10:25 ` [PATCH access-control/manager/proxmox v4 0/3] fix #5076: add support for open id audiences Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260420153332.414620-3-s.sterz@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox