applied: [PATCH v2 qemu-server] cloud-init: commit: activate volume early enough to fix regression with qcow2 on LVM

[Fiona Ebner <f.ebner@proxmox.com>]

Am 17.08.26 um 12:30 PM schrieb Fiona Ebner:
> Since pve-storage commit 05032c5 ("fix #7811: storage: lvm: reject
> allocation on format and volume name mismatch") and its follow-ups,
> cloud-init disks are named with a '.qcow2' extension on LVM storages
> with snapshot-as-volume-chain enabled.
> 
> This causes a regression, because volume_size_info() fails and returns
> undef when the qcow2 volume is not active. When the size cannot be
> determined, commit_cloudinit_disk() function assumes that the disk
> does not yet exist and tries to allocate new disk with the same name,
> which fails.
> 
>  # qm start 100
>  failed to stat '/dev/lvm/vm-100-cloudinit.qcow2'
>    Rounding up size to full physical extent 8.00 MiB
>  lvcreate 'lvm/vm-100-cloudinit.qcow2' error:   Logical Volume
>   "vm-100-cloudinit.qcow2" already exists in volume group "lvm"
> 
> Fix the issue by activating the volume early enough.
> 
> Note that activate_volumes() also activates the storage, which fixes
> another bug, since nothing ensured that the storage was active before.
> For a VM with just the cloud-init disk on the 'nfs' storage:
> 
>  # umount /mnt/pve/nfs && qm start 100
>  failed to stat '/mnt/pve/nfs/images/100/vm-100-cloudinit.raw'
>  disk image '/mnt/pve/nfs/images/100/vm-100-cloudinit.raw' already exists
> 
> Once there is a proper existence check function in the storage layer,
> that can be used instead. For vdisk_list(), not all plugin
> implementations filter early for $vollist, so there can be overhead
> and some plugins even might fail when there are issues with unrelated
> volumes. Even if using an eval block, if the cloud-init volume already
> exists, but vdisk_list() fails, it would be detected as the volume not
> existing and then allocation would fail. The current approach with
> activation avoids that an issue with a different volume blocks VM
> start.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>

Applied, with Dominik's feedback incorporated, thank you very much for
the review!

[1/1] cloud-init: commit: activate volume early enough to fix regression
      with qcow2 on LVM
      commit f0c2cc3bee10daadd153cbfae8e92d5678032a6a