public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: applied: [PATCH pve-manager v4 0/3] ui: prompt users for reload when web ui version changes
Date: Sun, 22 Nov 2026 03:26:53 +0100	[thread overview]
Message-ID: <179531332580.2146443.17709622985672325034.b4-ty@b4> (raw)
In-Reply-To: <20261120095235.1143525-1-d.csapak@proxmox.com>

On Fri, 20 Nov 2026 10:46:36 +0100, Dominik Csapak wrote:
> On some updates (like recently with ceph), the UI has new or better
> information about backend states, but the user must reload the page to
> get the new version, which might not be obvious.
> 
> To help users detect such outdated running UI versions, send the current
> one in the index and /nodes/{node}/version api call. The ui can then
> compare these and prompt the user to reload.
> 
> [...]

Applied, thanks!

While applying I replaced the empty failure callback with
`autoErrorAlert: false`, reworded a comment and made the subject of 2/3
singular.

On top I added the mtime of the pve-manager directory to the cache key of
pvemanagerlib.js and ext6-pve.css, like for the i18n files. Before, a
rebuild of the same version showed the notice, but Reload UI kept the old
cached files, as their URL and modification time stayed the same.

[1/3] api: factor out read_pwt_version and pwt_base_dir
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=0d9314fb48ec54e2464d1ae4a9cf073715d03e56
[2/3] api: provide UI version via index and /nodes/{node}/version
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=30b149eed8bb0b78bf8a253dbb8fdb70ecb6f422
[3/3] ui: workspace: show reload notice when UI packages were updated
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=2d457f31eb1f9a63d193e73a7bb0ca746cc43c0e




      parent reply	other threads:[~2026-11-22  2:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  9:46 [PATCH pve-manager v4 0/3] ui: prompt users for reload when web ui version changes Dominik Csapak
2026-11-20  9:46 ` [PATCH pve-manager v4 1/3] api: factor out read_pwt_version and pwt_base_dir Dominik Csapak
2026-11-20  9:46 ` [PATCH pve-manager v4 2/3] api: provide UI versions via index and /nodes/{node}/version Dominik Csapak
2026-11-20  9:46 ` [PATCH pve-manager v4 3/3] ui: workspace: show reload notice when UI packages were updated Dominik Csapak
2026-11-22  2:26 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179531332580.2146443.17709622985672325034.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal