From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 666F81FF0B2 for ; Sun, 22 Nov 2026 03:27:14 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id B11AC20AA6; Sun, 22 Nov 2026 03:27:13 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Dominik Csapak Subject: applied: [PATCH pve-manager v4 0/3] ui: prompt users for reload when web ui version changes Date: Sun, 22 Nov 2026 03:26:53 +0100 Message-ID: <179531332580.2146443.17709622985672325034.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261120095235.1143525-1-d.csapak@proxmox.com> References: <20261120095235.1143525-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795314425261 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.001 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BH67NJZ3FRFXL7JXOTDVJPLY6GFF24H2 X-Message-ID-Hash: BH67NJZ3FRFXL7JXOTDVJPLY6GFF24H2 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 20 Nov 2026 10:46:36 +0100, Dominik Csapak wrote: > On some updates (like recently with ceph), the UI has new or better > information about backend states, but the user must reload the page to > get the new version, which might not be obvious. > > To help users detect such outdated running UI versions, send the current > one in the index and /nodes/{node}/version api call. The ui can then > compare these and prompt the user to reload. > > [...] Applied, thanks! While applying I replaced the empty failure callback with `autoErrorAlert: false`, reworded a comment and made the subject of 2/3 singular. On top I added the mtime of the pve-manager directory to the cache key of pvemanagerlib.js and ext6-pve.css, like for the i18n files. Before, a rebuild of the same version showed the notice, but Reload UI kept the old cached files, as their URL and modification time stayed the same. [1/3] api: factor out read_pwt_version and pwt_base_dir https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=0d9314fb48ec54e2464d1ae4a9cf073715d03e56 [2/3] api: provide UI version via index and /nodes/{node}/version https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=30b149eed8bb0b78bf8a253dbb8fdb70ecb6f422 [3/3] ui: workspace: show reload notice when UI packages were updated https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=2d457f31eb1f9a63d193e73a7bb0ca746cc43c0e