public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [PATCH network v2] sdn: fabrics: only warn about a host vrf on a fabric interface
Date: Sat, 21 Nov 2026 21:59:00 +0100	[thread overview]
Message-ID: <179528709033497.3238989.1179537221795720705.b4-ty@b4> (raw)
In-Reply-To: <20261120185037.493949-1-g.goller@proxmox.com>

On Fri, 20 Nov 2026 19:50:36 +0100, Gabriel Goller wrote:
> A vrf set on a fabric interface made the whole SDN network config of
> the node fail, so zones and other fabrics were not updated either.
> Print a warning instead.
> 
> [...]

Applied, thanks!

Tested with a host VRF on an OpenFabric interface: the config is
generated now, with the warning, nice.

What I changed in your patch:
- Also check a host VRF named "0", which the API allows (falsy vs not
  defined).
- Test that a different host VRF on a zone fabric interface leaves the
  generated config unchanged.
- Separate the advice in the warning with a semicolon.

[1/1] sdn: fabrics: only warn about a host vrf on a fabric interface
      commit: 20c8b0904cdc22617922f233adb005857a22c78d




      reply	other threads:[~2026-11-21 20:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 18:50 [PATCH network v2] sdn: fabrics: only warn about a host vrf on a fabric interface Gabriel Goller
2026-11-21 20:59 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179528709033497.3238989.1179537221795720705.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal