From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id C66F21FF0E4 for ; Sat, 21 Nov 2026 21:59:48 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4D8F92170D; Sat, 21 Nov 2026 21:59:22 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Gabriel Goller Subject: Re: [PATCH network v2] sdn: fabrics: only warn about a host vrf on a fabric interface Date: Sat, 21 Nov 2026 21:59:00 +0100 Message-ID: <179528709033497.3238989.1179537221795720705.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261120185037.493949-1-g.goller@proxmox.com> References: <20261120185037.493949-1-g.goller@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795294756262 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.147 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NNMECFRGM73NUOZN47ZLOV27TV27XLOQ X-Message-ID-Hash: NNMECFRGM73NUOZN47ZLOV27TV27XLOQ X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 20 Nov 2026 19:50:36 +0100, Gabriel Goller wrote: > A vrf set on a fabric interface made the whole SDN network config of > the node fail, so zones and other fabrics were not updated either. > Print a warning instead. > > [...] Applied, thanks! Tested with a host VRF on an OpenFabric interface: the config is generated now, with the warning, nice. What I changed in your patch: - Also check a host VRF named "0", which the API allows (falsy vs not defined). - Test that a different host VRF on a zone fabric interface leaves the generated config unchanged. - Separate the advice in the warning with a semicolon. [1/1] sdn: fabrics: only warn about a host vrf on a fabric interface commit: 20c8b0904cdc22617922f233adb005857a22c78d