public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [PATCH network v2] sdn: zones: warn about host interfaces in a missing zone VRF
Date: Sat, 21 Nov 2026 21:59:01 +0100	[thread overview]
Message-ID: <179528709033465.3238989.1297853555045366772.b4-ty@b4> (raw)
In-Reply-To: <20261120183116.478378-1-g.goller@proxmox.com>

On Fri, 20 Nov 2026 19:31:15 +0100, Gabriel Goller wrote:
> Disabling dedicated-vrf, removing the node from a zone or deleting the
> zone removes its VRF, but host interfaces may still be in it. ifreload
> then cannot enslave them or add their gateway, which is easy to miss
> in the apply log.
> 
> [...]

Applied, thanks!

Tested on a node outside the zone: an interface left in the zone's VRF
gets the warning.

What I changed in your patch:
- Fold in your vrf_table fix.
- Only count a generated stanza for the VRF if it sets a VRF table.
- Say the interface "is configured to use" the VRF, as the check reads
  the config, not the running state.
- Add a test.

[1/1] sdn: zones: warn about host interfaces in a missing zone VRF
      commit: 1505cbf36cc3d4e7e25be097807a8c0fb85c0723




      parent reply	other threads:[~2026-11-21 20:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 18:31 [PATCH network v2] sdn: zones: warn about host interfaces in a missing zone VRF Gabriel Goller
2026-11-20 18:59 ` Gabriel Goller
2026-11-21 20:59 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179528709033465.3238989.1297853555045366772.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal