From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 59FF21FF0E4 for ; Sat, 21 Nov 2026 21:59:41 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id EAD29216DC; Sat, 21 Nov 2026 21:59:21 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Gabriel Goller Subject: Re: [PATCH network v2] sdn: zones: warn about host interfaces in a missing zone VRF Date: Sat, 21 Nov 2026 21:59:01 +0100 Message-ID: <179528709033465.3238989.1297853555045366772.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261120183116.478378-1-g.goller@proxmox.com> References: <20261120183116.478378-1-g.goller@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795294756358 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.147 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XZ5MO5OVB3R3VPPMHPQIBJFNRFSAOAE3 X-Message-ID-Hash: XZ5MO5OVB3R3VPPMHPQIBJFNRFSAOAE3 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 20 Nov 2026 19:31:15 +0100, Gabriel Goller wrote: > Disabling dedicated-vrf, removing the node from a zone or deleting the > zone removes its VRF, but host interfaces may still be in it. ifreload > then cannot enslave them or add their gateway, which is easy to miss > in the apply log. > > [...] Applied, thanks! Tested on a node outside the zone: an interface left in the zone's VRF gets the warning. What I changed in your patch: - Fold in your vrf_table fix. - Only count a generated stanza for the VRF if it sets a VRF table. - Say the interface "is configured to use" the VRF, as the check reads the config, not the running state. - Add a test. [1/1] sdn: zones: warn about host interfaces in a missing zone VRF commit: 1505cbf36cc3d4e7e25be097807a8c0fb85c0723