public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Stefan Hanreich <s.hanreich@proxmox.com>
Subject: Re: [PATCH docs/manager/network/proxmox-perl-rs 00/10] WireGuard fabric follow-ups
Date: Sat, 21 Nov 2026 21:59:02 +0100	[thread overview]
Message-ID: <179528709033349.3238989.1914948970335621663.b4-ty@b4> (raw)
In-Reply-To: <20261120160026.512565-1-s.hanreich@proxmox.com>

On Fri, 20 Nov 2026 17:00:15 +0100, Stefan Hanreich wrote:
> This series contains follow-ups for the WireGuard fabric status
> reporting and its UI:
> 
> [...]

Applied, thanks!

Tested on a three-node cluster: empty status outside the fabric, '-'
for missing values, keepalive, Reload and the MTU and port checks all
work.

What I changed in your patches:
- Use emptyCellText instead of the '-' renderers, which skipped the
  HTML escaping, for example of OpenFabric neighbor names (xss).
- Also return an empty status for a node with the name of an external
  peer, instead of an error.
- Publish invalid MTU and port input as typed, as the number field
  turned "1400abc" into 1400.
- Require the listen port, as the API needs one.
- Smaller test and wording changes.

What I added on top:
- aee658c ("pve-rs: sdn: status: skip external peers with the name of
  the node"): the resource tree showed the fabric as not ok because of
  such a peer.
- dc7078b15 ("ui: sdn: fabrics: wireguard: do not mark unchanged nodes
  as modified").
- Mark invalid interfaces in the list.
- Do not propose a listen port that is in use.
- Add Reload for the other protocols and list the interfaces in the
  status index.

I kept the type in the interface status optional, although the schema
had it as required: nothing in our UI or PDM uses it, and the WG status
only shipped with the last release.

[proxmox-perl-rs]
[01/10] pve-rs: sdn: fabrics: wireguard: return empty status for non-member nodes
      commit: e9005cd3082780bb0aa2cc57962941f4a727e5cf
[02/10] pve-rs: sdn: status: wireguard: only report type of WireGuard interfaces
      commit: ee7f0f93fa3265b9905754ee8fde8e3bdeb306b9
[03/10] pve-rs: sdn: status: wireguard: only report running interface keys and ports
      commit: 6c820fcefe9a888a403c8c9123b606087adea56e

[pve-docs]
[10/10] sdn: fabrics: wireguard: document status values and keepalive column
      commit: c4c04fdf222f1848dc2536dbdac0b90d489fad41

[pve-manager]
[05/10] ui: sdn: fabrics: wireguard: block saving invalid interface values
      commit: 3768f41564fd77dbc547ead810acb5c201928850
[06/10] ui: sdn: fabrics: wireguard: show persistent keepalive of neighbors
      commit: a6006f4404cf79b636450853a790c850b0e81e7c
[07/10] ui: sdn: fabrics: wireguard: show '-' for unknown status values
      commit: 88360126917b34a4a041283dcb88273befc0b5d7
[08/10] ui: sdn: fabrics: wireguard: add reload button to status grids
      commit: 2c77ce6a24cab8ea13bd8651297983c8fa026bd7
[09/10] ui: sdn: fabrics: wireguard: support resetting the interfaces
      commit: 8cdd26018d127c7807fc74b27ae56a5e3e20f56c

[pve-network]
[04/10] api: fabric status: document omitted WireGuard interface values
      commit: 8538bd22aebd4d3ebeb6030e43279492666e0f0e




      parent reply	other threads:[~2026-11-21 21:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 16:00 [PATCH docs/manager/network/proxmox-perl-rs 00/10] WireGuard fabric follow-ups Stefan Hanreich
2026-11-20 16:00 ` [PATCH proxmox-perl-rs 01/10] pve-rs: sdn: fabrics: wireguard: return empty status for non-member nodes Stefan Hanreich
2026-11-20 16:00 ` [PATCH proxmox-perl-rs 02/10] pve-rs: sdn: status: wireguard: only report type of WireGuard interfaces Stefan Hanreich
2026-11-20 16:00 ` [PATCH proxmox-perl-rs 03/10] pve-rs: sdn: status: wireguard: only report running interface keys and ports Stefan Hanreich
2026-11-20 16:00 ` [PATCH pve-network 04/10] api: fabric status: document omitted WireGuard interface values Stefan Hanreich
2026-11-20 16:00 ` [PATCH pve-manager 05/10] ui: sdn: fabrics: wireguard: block saving invalid " Stefan Hanreich
2026-11-20 16:00 ` [PATCH pve-manager 06/10] ui: sdn: fabrics: wireguard: show persistent keepalive of neighbors Stefan Hanreich
2026-11-20 16:00 ` [PATCH pve-manager 07/10] ui: sdn: fabrics: wireguard: show '-' for unknown status values Stefan Hanreich
2026-11-20 16:00 ` [PATCH pve-manager 08/10] ui: sdn: fabrics: wireguard: add reload button to status grids Stefan Hanreich
2026-11-20 16:00 ` [PATCH pve-manager 09/10] ui: sdn: fabrics: wireguard: support resetting the interfaces Stefan Hanreich
2026-11-20 16:00 ` [PATCH pve-docs 10/10] sdn: fabrics: wireguard: document status values and keepalive column Stefan Hanreich
2026-11-21 20:59 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179528709033349.3238989.1914948970335621663.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.hanreich@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal