From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 418881FF0E4 for ; Sat, 21 Nov 2026 22:00:14 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 943B62177D; Sat, 21 Nov 2026 21:59:23 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Stefan Hanreich Subject: Re: [PATCH docs/manager/network/proxmox-perl-rs 00/10] WireGuard fabric follow-ups Date: Sat, 21 Nov 2026 21:59:02 +0100 Message-ID: <179528709033349.3238989.1914948970335621663.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261120160026.512565-1-s.hanreich@proxmox.com> References: <20261120160026.512565-1-s.hanreich@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795294756419 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: Y5NCPF3R3X5JNBMKFJPYPLN3YAIH5RQL X-Message-ID-Hash: Y5NCPF3R3X5JNBMKFJPYPLN3YAIH5RQL X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 20 Nov 2026 17:00:15 +0100, Stefan Hanreich wrote: > This series contains follow-ups for the WireGuard fabric status > reporting and its UI: > > [...] Applied, thanks! Tested on a three-node cluster: empty status outside the fabric, '-' for missing values, keepalive, Reload and the MTU and port checks all work. What I changed in your patches: - Use emptyCellText instead of the '-' renderers, which skipped the HTML escaping, for example of OpenFabric neighbor names (xss). - Also return an empty status for a node with the name of an external peer, instead of an error. - Publish invalid MTU and port input as typed, as the number field turned "1400abc" into 1400. - Require the listen port, as the API needs one. - Smaller test and wording changes. What I added on top: - aee658c ("pve-rs: sdn: status: skip external peers with the name of the node"): the resource tree showed the fabric as not ok because of such a peer. - dc7078b15 ("ui: sdn: fabrics: wireguard: do not mark unchanged nodes as modified"). - Mark invalid interfaces in the list. - Do not propose a listen port that is in use. - Add Reload for the other protocols and list the interfaces in the status index. I kept the type in the interface status optional, although the schema had it as required: nothing in our UI or PDM uses it, and the WG status only shipped with the last release. [proxmox-perl-rs] [01/10] pve-rs: sdn: fabrics: wireguard: return empty status for non-member nodes commit: e9005cd3082780bb0aa2cc57962941f4a727e5cf [02/10] pve-rs: sdn: status: wireguard: only report type of WireGuard interfaces commit: ee7f0f93fa3265b9905754ee8fde8e3bdeb306b9 [03/10] pve-rs: sdn: status: wireguard: only report running interface keys and ports commit: 6c820fcefe9a888a403c8c9123b606087adea56e [pve-docs] [10/10] sdn: fabrics: wireguard: document status values and keepalive column commit: c4c04fdf222f1848dc2536dbdac0b90d489fad41 [pve-manager] [05/10] ui: sdn: fabrics: wireguard: block saving invalid interface values commit: 3768f41564fd77dbc547ead810acb5c201928850 [06/10] ui: sdn: fabrics: wireguard: show persistent keepalive of neighbors commit: a6006f4404cf79b636450853a790c850b0e81e7c [07/10] ui: sdn: fabrics: wireguard: show '-' for unknown status values commit: 88360126917b34a4a041283dcb88273befc0b5d7 [08/10] ui: sdn: fabrics: wireguard: add reload button to status grids commit: 2c77ce6a24cab8ea13bd8651297983c8fa026bd7 [09/10] ui: sdn: fabrics: wireguard: support resetting the interfaces commit: 8cdd26018d127c7807fc74b27ae56a5e3e20f56c [pve-network] [04/10] api: fabric status: document omitted WireGuard interface values commit: 8538bd22aebd4d3ebeb6030e43279492666e0f0e