public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Stefan Hanreich <s.hanreich@proxmox.com>
Subject: Re: [PATCH proxmox{-ve-rs,-firewall} 0/4] sdn: zone VRF conntrack zones: follow-ups
Date: Sat, 21 Nov 2026 21:59:03 +0100	[thread overview]
Message-ID: <179528709033174.3238989.4282255440884895856.b4-ty@b4> (raw)
In-Reply-To: <20261120152811.473269-1-s.hanreich@proxmox.com>

On Fri, 20 Nov 2026 16:28:05 +0100, Stefan Hanreich wrote:
> The VRF device of a zone is only created on the nodes of the zone, but
> proxmox-firewall set the conntrack zone for every interface with the
> name of the VRF device and the interfaces enslaved to it on all nodes.
> So on a node that is not part of the zone, a manually created interface
> with that name and its members got the conntrack zone as well.
> 
> [...]

Applied, thanks!

Tested on a three-node cluster: a node outside both zones no longer maps
a VRF of the same name, while the zone nodes keep theirs.

What I changed in your patches:
- Move the firewall's dependency bump into the patch that switches to
  for_node, so each commit builds.
- Cover a node outside the zone in the bridge test and add Fixes:
  trailers to point to the commit that introduced it.

What I added on top:
- 96b763f ("sdn: check zone nodes the same way for static routes and
  conntrack"): the static routes counted a node listed with a false
  value, the conntrack zones did not.

[proxmox-firewall]
[3/4] firewall: config: query the network interfaces only once
      commit: 3aa9261960839bf9cffbaa3e81dba99ab82cbb5a
[4/4] firewall: sdn: only apply the conntrack zones of zones on this node
      commit: 01ef40d6f92a289695af59f2fc33e46f45656039

[proxmox-ve-rs]
[1/4] sdn: config: read the nodes of zones from the running config
      commit: 95c6c265e53674f26946afc8c4c255a9d2aa7232
[2/4] sdn: conntrack: only map the VRFs of zones that exist on the node
      commit: 8324928fec0fb7250bbb22b885d7359255ffc478




      parent reply	other threads:[~2026-11-21 21:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 15:28 [PATCH proxmox{-ve-rs,-firewall} 0/4] sdn: zone VRF conntrack zones: follow-ups Stefan Hanreich
2026-11-20 15:28 ` [PATCH proxmox-ve-rs 1/4] sdn: config: read the nodes of zones from the running config Stefan Hanreich
2026-11-20 15:28 ` [PATCH proxmox-ve-rs 2/4] sdn: conntrack: only map the VRFs of zones that exist on the node Stefan Hanreich
2026-11-20 15:28 ` [PATCH proxmox-firewall 3/4] firewall: config: query the network interfaces only once Stefan Hanreich
2026-11-20 15:28 ` [PATCH proxmox-firewall 4/4] firewall: sdn: only apply the conntrack zones of zones on this node Stefan Hanreich
2026-11-21 20:59 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179528709033174.3238989.4282255440884895856.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.hanreich@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal