From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 07E1E1FF0E4 for ; Sat, 21 Nov 2026 22:00:23 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 1864F2178D; Sat, 21 Nov 2026 21:59:24 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Stefan Hanreich Subject: Re: [PATCH proxmox{-ve-rs,-firewall} 0/4] sdn: zone VRF conntrack zones: follow-ups Date: Sat, 21 Nov 2026 21:59:03 +0100 Message-ID: <179528709033174.3238989.4282255440884895856.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261120152811.473269-1-s.hanreich@proxmox.com> References: <20261120152811.473269-1-s.hanreich@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795294756478 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.146 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HYXYKU3FRJZJD5Q254EBCNTYUQVRNBI4 X-Message-ID-Hash: HYXYKU3FRJZJD5Q254EBCNTYUQVRNBI4 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 20 Nov 2026 16:28:05 +0100, Stefan Hanreich wrote: > The VRF device of a zone is only created on the nodes of the zone, but > proxmox-firewall set the conntrack zone for every interface with the > name of the VRF device and the interfaces enslaved to it on all nodes. > So on a node that is not part of the zone, a manually created interface > with that name and its members got the conntrack zone as well. > > [...] Applied, thanks! Tested on a three-node cluster: a node outside both zones no longer maps a VRF of the same name, while the zone nodes keep theirs. What I changed in your patches: - Move the firewall's dependency bump into the patch that switches to for_node, so each commit builds. - Cover a node outside the zone in the bridge test and add Fixes: trailers to point to the commit that introduced it. What I added on top: - 96b763f ("sdn: check zone nodes the same way for static routes and conntrack"): the static routes counted a node listed with a false value, the conntrack zones did not. [proxmox-firewall] [3/4] firewall: config: query the network interfaces only once commit: 3aa9261960839bf9cffbaa3e81dba99ab82cbb5a [4/4] firewall: sdn: only apply the conntrack zones of zones on this node commit: 01ef40d6f92a289695af59f2fc33e46f45656039 [proxmox-ve-rs] [1/4] sdn: config: read the nodes of zones from the running config commit: 95c6c265e53674f26946afc8c4c255a9d2aa7232 [2/4] sdn: conntrack: only map the VRFs of zones that exist on the node commit: 8324928fec0fb7250bbb22b885d7359255ffc478