public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [PATCH manager] ui: sdn: fabrics: do not show WireGuard interfaces for fabrics in a zone
Date: Sat, 21 Nov 2026 21:58:57 +0100	[thread overview]
Message-ID: <179528709033071.3238989.2962977676002148321.b4-ty@b4> (raw)
In-Reply-To: <20261120152657.275504-1-g.goller@proxmox.com>

On Fri, 20 Nov 2026 16:26:56 +0100, Gabriel Goller wrote:
> An OSPF or BGP fabric in a zone moves its interfaces into the VRF of
> the zone. For a WireGuard interface, ifupdown2 merges the stanzas of
> both fabrics into:
> 
> [...]

Applied, thanks!

What I changed in your patch:
- WG interfaces the node already used showed "Interface does not exist
  on node", as none were loaded anymore. Now the used ones are loaded
  and get a warning that zone fabrics cannot use them.
- Hide WG interfaces from /etc/network/interfaces.

What I added on top:
- ac8debe ("api: fabrics: reject WireGuard interfaces for fabrics in a
  zone"): the API accepted them too. It only checks on node writes, so
  existing configs still load and can be fixed.
- bbc6e74b9 ("ui: sdn: fabrics: node edit: only use the loaded data if
  loading worked"): a failed load threw a second error.
- The docs now say that zone fabrics cannot use WG interfaces.

[1/1] ui: sdn: fabrics: do not show WireGuard interfaces for fabrics in a zone
      commit: eef80582fc5a61372be7e3f58cc084f544915be1




      reply	other threads:[~2026-11-21 20:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 15:26 [PATCH manager] ui: sdn: fabrics: do not show WireGuard interfaces for fabrics in a zone Gabriel Goller
2026-11-21 20:58 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179528709033071.3238989.2962977676002148321.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal