From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id AB6261FF0E4 for ; Sat, 21 Nov 2026 21:59:32 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 8052A216A3; Sat, 21 Nov 2026 21:59:21 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Gabriel Goller Subject: Re: [PATCH manager] ui: sdn: fabrics: do not show WireGuard interfaces for fabrics in a zone Date: Sat, 21 Nov 2026 21:58:57 +0100 Message-ID: <179528709033071.3238989.2962977676002148321.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261120152657.275504-1-g.goller@proxmox.com> References: <20261120152657.275504-1-g.goller@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795294756006 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.147 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GJV7ZHLBSHEFK2X226RH36CYWCYKTWJM X-Message-ID-Hash: GJV7ZHLBSHEFK2X226RH36CYWCYKTWJM X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 20 Nov 2026 16:26:56 +0100, Gabriel Goller wrote: > An OSPF or BGP fabric in a zone moves its interfaces into the VRF of > the zone. For a WireGuard interface, ifupdown2 merges the stanzas of > both fabrics into: > > [...] Applied, thanks! What I changed in your patch: - WG interfaces the node already used showed "Interface does not exist on node", as none were loaded anymore. Now the used ones are loaded and get a warning that zone fabrics cannot use them. - Hide WG interfaces from /etc/network/interfaces. What I added on top: - ac8debe ("api: fabrics: reject WireGuard interfaces for fabrics in a zone"): the API accepted them too. It only checks on node writes, so existing configs still load and can be fixed. - bbc6e74b9 ("ui: sdn: fabrics: node edit: only use the loaded data if loading worked"): a failed load threw a second error. - The docs now say that zone fabrics cannot use WG interfaces. [1/1] ui: sdn: fabrics: do not show WireGuard interfaces for fabrics in a zone commit: eef80582fc5a61372be7e3f58cc084f544915be1