public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Lucas Barros <lucasbarros.kam@gmail.com>
Subject: applied: [PATCH storage v2] fix #8211: disks: detect SAS hard disks as hdd
Date: Fri, 20 Nov 2026 13:28:35 +0100	[thread overview]
Message-ID: <179517771293.271913.11747257204588197059.b4-ty@b4> (raw)
In-Reply-To: <20261109134143.72587-1-lucasbarros.kam@gmail.com>

On Mon, 09 Nov 2026 10:41:43 -0300, Lucas Barros wrote:
> SAS hard disks were listed with type 'unknown' and rpm -1. For a
> rotational device the type 'hdd' is only set if a rotation rate is
> known, and that rate is only read from the ID_ATA_ROTATION_RATE_RPM
> udev property, which only exists for ATA devices.
> 
> SCSI devices report their nominal rotation rate in the block device
> characteristics VPD page (0xb1), which the kernel exposes as
> device/vpd_pgb1 in sysfs. Use that as a fallback if udev does not
> provide a rotation rate, so SAS hard disks are listed as 'hdd' with
> their actual rpm. Devices without that page, or which do not report a
> rotation rate there, keep the current behavior.
> 
> [...]

Applied, thanks!

[1/1] fix #8211: disks: detect SAS hard disks as hdd
      https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=38de791385707b676403dda9a7ef8cf7ec91f889




      reply	other threads:[~2026-11-20 12:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-07 22:08 [PATCH storage] fix #8211: disks: detect SAS hard disks as hdd Lucas Barros
2026-11-09 13:41 ` [PATCH storage v2] " Lucas Barros
2026-11-20 12:28   ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179517771293.271913.11747257204588197059.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=lucasbarros.kam@gmail.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal