From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 85A2E1FF0AF for ; Fri, 20 Nov 2026 13:29:25 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 01EE721702; Fri, 20 Nov 2026 13:29:23 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Lucas Barros Subject: applied: [PATCH storage v2] fix #8211: disks: detect SAS hard disks as hdd Date: Fri, 20 Nov 2026 13:28:35 +0100 Message-ID: <179517771293.271913.11747257204588197059.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261109134143.72587-1-lucasbarros.kam@gmail.com> References: <20261109134143.72587-1-lucasbarros.kam@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795177758044 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.148 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BCYQWGUD3MFCXOL7GLCU7HWHCSSFMG7O X-Message-ID-Hash: BCYQWGUD3MFCXOL7GLCU7HWHCSSFMG7O X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 09 Nov 2026 10:41:43 -0300, Lucas Barros wrote: > SAS hard disks were listed with type 'unknown' and rpm -1. For a > rotational device the type 'hdd' is only set if a rotation rate is > known, and that rate is only read from the ID_ATA_ROTATION_RATE_RPM > udev property, which only exists for ATA devices. > > SCSI devices report their nominal rotation rate in the block device > characteristics VPD page (0xb1), which the kernel exposes as > device/vpd_pgb1 in sysfs. Use that as a fallback if udev does not > provide a rotation rate, so SAS hard disks are listed as 'hdd' with > their actual rpm. Devices without that page, or which do not report a > rotation rate there, keep the current behavior. > > [...] Applied, thanks! [1/1] fix #8211: disks: detect SAS hard disks as hdd https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=38de791385707b676403dda9a7ef8cf7ec91f889