public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH ceph squid-stable-9 v3 0/1] patches: link the PVE cephx migration docs in the insecure key warnings
@ 2026-11-12  8:20 Kefu Chai
  2026-11-12  8:20 ` [PATCH ceph squid-stable-9 v3 1/1] " Kefu Chai
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Kefu Chai @ 2026-11-12  8:20 UTC (permalink / raw)
  To: pve-devel

The point releases added health checks for keys, service tickets and
cipher settings that still use aes, and a PVE user picking up the
release sees AUTH_INSECURE_KEYS_ALLOWED in `ceph health` with no hint
what to do about it. Append the PVE cephx migration guide's URL to
that check's summary, so the output itself points at the documented
migration path.

The sibling patch for tentacle-stable-9 is resent separately.

Both patches were tested in a lab environment, on three-node clusters
running packages built from these branches at 19.2.7-pve1 and
20.2.5-pve1: the URL shows up in `ceph health`, `ceph -s`, `ceph
health detail` and the cluster log while the monitors still allow
aes, and it disappears once the allowed ciphers are restricted to
aes256k.

Changes since v2:

* rebase onto the Squid 19.2.7 import. The quilt patch itself is
  unchanged.

Link to v2: https://lore.proxmox.com/pve-devel/20261016103138.3896717-1-k.chai@proxmox.com/

Kefu Chai (1):
  patches: link the PVE cephx migration docs in the insecure key warnings

 patches/0058-mon-AuthMonitor-link-the-PVE-cephx-migration-docs-in.patch | 53 +++++++++++++++++++
 patches/series                                                          |  1 +
 2 files changed, 54 insertions(+)

--
2.47.3





^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH ceph squid-stable-9 v3 1/1] patches: link the PVE cephx migration docs in the insecure key warnings
  2026-11-12  8:20 [PATCH ceph squid-stable-9 v3 0/1] patches: link the PVE cephx migration docs in the insecure key warnings Kefu Chai
@ 2026-11-12  8:20 ` Kefu Chai
  2026-11-12 10:56 ` [PATCH ceph squid-stable-9 v3 0/1] " Maximiliano Sandoval
  2026-11-18 14:51 ` applied: " Thomas Lamprecht
  2 siblings, 0 replies; 5+ messages in thread
From: Kefu Chai @ 2026-11-12  8:20 UTC (permalink / raw)
  To: pve-devel

Ceph 19.2.6 and 20.2.4 added health checks for keys, service tickets and
cipher settings that still use aes. A node picking up the point release
starts reporting them, and the summary that `ceph -s` prints says only
that something is insecure, not what to do about it. The migration on
PVE goes through pve-cephx-rotate-service-keys, which also updates the
key copies that PVE manages, so the upstream procedure is not what a
user should follow here.

The web interface already explains every one of these checks and puts
the guide next to it, but a user reading `ceph -s` or `ceph health` over
ssh gets the summary and nothing else, so the link has to be in the
summary too.

Append it to AUTH_INSECURE_KEYS_ALLOWED and to nothing else. That check
is raised for as long as the monitors still allow aes, and the allowed
ciphers are restricted in the last of the three documented steps and
only by the helper, so the link tracks whether the migration is
finished. The other checks clear earlier: the two with error severity go
away in step 1, the rotating service key warning expires by itself, and
the last two are the ones the PVE docs tell users to mute while an
incompatible client keeps the migration from finishing. Appending the
url to those as well would print it up to six times in a single
`ceph health` line and in the cluster log.

The link is only useful on PVE, so there is no upstream commit behind
this patch: it is ours, and it stays in the series.

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
---
 ...link-the-PVE-cephx-migration-docs-in.patch | 53 +++++++++++++++++++
 patches/series                                |  1 +
 2 files changed, 54 insertions(+)
 create mode 100644 patches/0058-mon-AuthMonitor-link-the-PVE-cephx-migration-docs-in.patch

diff --git a/patches/0058-mon-AuthMonitor-link-the-PVE-cephx-migration-docs-in.patch b/patches/0058-mon-AuthMonitor-link-the-PVE-cephx-migration-docs-in.patch
new file mode 100644
index 0000000000..5388239b82
--- /dev/null
+++ b/patches/0058-mon-AuthMonitor-link-the-PVE-cephx-migration-docs-in.patch
@@ -0,0 +1,53 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Kefu Chai <k.chai@proxmox.com>
+Date: Thu, 15 Oct 2026 18:34:37 +0800
+Subject: [PATCH] mon/AuthMonitor: link the PVE cephx migration docs in
+ insecure key warnings
+
+Ceph 19.2.6 and 20.2.4 added health checks for keys, service tickets
+and cipher settings that still use aes, so PVE users can see them right
+after a point release upgrade without knowing what to do next. The
+migration has to be done with the pve-cephx-rotate-service-keys helper,
+which also updates the key copies managed by PVE, instead of the
+upstream procedure.
+
+The web interface explains each of these checks and links the guide
+next to them, but somebody reading "ceph -s" or "ceph health" over ssh
+gets the summary and nothing else, so the summary has to carry the
+link.
+
+Only AUTH_INSECURE_KEYS_ALLOWED carries it. That check is raised for as
+long as the monitors still allow aes, and the documented procedure
+restricts the allowed ciphers in its last step and only through the
+helper, so the check tracks whether the migration is finished. The
+others clear earlier: the two error severity ones go away in step 1,
+the rotating service key warning expires by itself, and the last two
+are the ones the PVE docs tell users to mute while an incompatible
+client keeps the migration from finishing. Linking those as well would
+repeat the same url up to six times in one "ceph health" line and in
+the cluster log.
+
+The summary points at the PVE documentation, so this change is not
+meant for upstream. It lives in the Proxmox patch series.
+
+Signed-off-by: Kefu Chai <k.chai@proxmox.com>
+---
+ src/mon/AuthMonitor.cc | 5 ++++-
+ 1 file changed, 4 insertions(+), 1 deletion(-)
+
+diff --git a/src/mon/AuthMonitor.cc b/src/mon/AuthMonitor.cc
+index 00d3fe99344..434470c537b 100644
+--- a/src/mon/AuthMonitor.cc
++++ b/src/mon/AuthMonitor.cc
+@@ -498,7 +498,10 @@ bool AuthMonitor::check_health()
+       }
+     }
+     if (!details.empty()) {
+-      auto& check = next.add("AUTH_INSECURE_KEYS_ALLOWED", HEALTH_WARN, "Monitors are configured to allow auth using insecure key types", details.size());
++      auto& check = next.add("AUTH_INSECURE_KEYS_ALLOWED", HEALTH_WARN,
++                             "Monitors are configured to allow auth using insecure key types"
++                             ", see https://pve.proxmox.com/pve-docs/chapter-pveceph.html#pveceph_cephx_migration",
++                             details.size());
+       for (auto& detail : details) {
+         check.detail.push_back(detail);
+       }
diff --git a/patches/series b/patches/series
index f3567c88f1..2df6c5ea64 100644
--- a/patches/series
+++ b/patches/series
@@ -55,3 +55,4 @@
 0055-auth-cephx-track-pending-key-use-per-accepted-sessio.patch
 0056-auth-cephx-allow-manual-pending-key-promotion-for-cl.patch
 0057-mon-record-which-key-authenticated-a-session.patch
+0058-mon-AuthMonitor-link-the-PVE-cephx-migration-docs-in.patch
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH ceph squid-stable-9 v3 0/1] patches: link the PVE cephx migration docs in the insecure key warnings
  2026-11-12  8:20 [PATCH ceph squid-stable-9 v3 0/1] patches: link the PVE cephx migration docs in the insecure key warnings Kefu Chai
  2026-11-12  8:20 ` [PATCH ceph squid-stable-9 v3 1/1] " Kefu Chai
@ 2026-11-12 10:56 ` Maximiliano Sandoval
  2026-11-18  4:23   ` Kefu Chai
  2026-11-18 14:51 ` applied: " Thomas Lamprecht
  2 siblings, 1 reply; 5+ messages in thread
From: Maximiliano Sandoval @ 2026-11-12 10:56 UTC (permalink / raw)
  To: Kefu Chai; +Cc: pve-devel

Kefu Chai <k.chai@proxmox.com> writes:

> The point releases added health checks for keys, service tickets and
> cipher settings that still use aes, and a PVE user picking up the
> release sees AUTH_INSECURE_KEYS_ALLOWED in `ceph health` with no hint
> what to do about it. Append the PVE cephx migration guide's URL to
> that check's summary, so the output itself points at the documented
> migration path.
>
> The sibling patch for tentacle-stable-9 is resent separately.
>
> Both patches were tested in a lab environment, on three-node clusters
> running packages built from these branches at 19.2.7-pve1 and
> 20.2.5-pve1: the URL shows up in `ceph health`, `ceph -s`, `ceph
> health detail` and the cluster log while the monitors still allow
> aes, and it disappears once the allowed ciphers are restricted to
> aes256k.
>
> Changes since v2:
>
> * rebase onto the Squid 19.2.7 import. The quilt patch itself is
>   unchanged.
>
> Link to v2: https://lore.proxmox.com/pve-devel/20261016103138.3896717-1-k.chai@proxmox.com/
>
> Kefu Chai (1):
>   patches: link the PVE cephx migration docs in the insecure key warnings
>
>  patches/0058-mon-AuthMonitor-link-the-PVE-cephx-migration-docs-in.patch | 53 +++++++++++++++++++
>  patches/series                                                          |  1 +
>  2 files changed, 54 insertions(+)

Tested creating a cluster with ceph 19.2.3-pve4 with a single VM using a
rbd storage. Upgraded the cluster to 19.2.7 with this patch applied and
carried the cephx key migration.

It all worked as expected. After restarting the first monitor after the
upgrade, ceph -s displayed as expected:

Monitors are configured to allow auth using insecure key types, see https://pve.proxmox.com/pve-docs/chapter-pveceph.html#pveceph_cephx_migration

Tested-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
Reviewed-by: Maximiliano Sandoval <m.sandoval@proxmox.com>

-- 
Maximiliano




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH ceph squid-stable-9 v3 0/1] patches: link the PVE cephx migration docs in the insecure key warnings
  2026-11-12 10:56 ` [PATCH ceph squid-stable-9 v3 0/1] " Maximiliano Sandoval
@ 2026-11-18  4:23   ` Kefu Chai
  0 siblings, 0 replies; 5+ messages in thread
From: Kefu Chai @ 2026-11-18  4:23 UTC (permalink / raw)
  To: m.sandoval; +Cc: pve-devel

Hi Maximiliano,

thanks a lot for testing this, and for going through the whole
upgrade with the key migration on top, that's the part I was
least sure about! Nice to see the URL show up right after the
first monitor restart too, since that's when people run into
the warning.




^ permalink raw reply	[flat|nested] 5+ messages in thread

* applied: [PATCH ceph squid-stable-9 v3 0/1] patches: link the PVE cephx migration docs in the insecure key warnings
  2026-11-12  8:20 [PATCH ceph squid-stable-9 v3 0/1] patches: link the PVE cephx migration docs in the insecure key warnings Kefu Chai
  2026-11-12  8:20 ` [PATCH ceph squid-stable-9 v3 1/1] " Kefu Chai
  2026-11-12 10:56 ` [PATCH ceph squid-stable-9 v3 0/1] " Maximiliano Sandoval
@ 2026-11-18 14:51 ` Thomas Lamprecht
  2 siblings, 0 replies; 5+ messages in thread
From: Thomas Lamprecht @ 2026-11-18 14:51 UTC (permalink / raw)
  To: pve-devel, Kefu Chai

On Thu, 12 Nov 2026 16:20:58 +0800, Kefu Chai wrote:
> The point releases added health checks for keys, service tickets and
> cipher settings that still use aes, and a PVE user picking up the
> release sees AUTH_INSECURE_KEYS_ALLOWED in `ceph health` with no hint
> what to do about it. Append the PVE cephx migration guide's URL to
> that check's summary, so the output itself points at the documented
> migration path.
> 
> [...]

Applied, thanks!

[1/1] patches: link the PVE cephx migration docs in the insecure key warnings
      commit: d456e3571a0c880133fd16828962a9288a18d75b




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-11-18 14:51 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-12  8:20 [PATCH ceph squid-stable-9 v3 0/1] patches: link the PVE cephx migration docs in the insecure key warnings Kefu Chai
2026-11-12  8:20 ` [PATCH ceph squid-stable-9 v3 1/1] " Kefu Chai
2026-11-12 10:56 ` [PATCH ceph squid-stable-9 v3 0/1] " Maximiliano Sandoval
2026-11-18  4:23   ` Kefu Chai
2026-11-18 14:51 ` applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal