public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Cc: Jonas Theisen <j.theisen@proxmox.com>
Subject: applied: [PATCH pve-manager v4 1/2] ui: resource tree: use 'diskuse' instead of calculating every time
Date: Mon, 16 Nov 2026 12:04:50 +0100	[thread overview]
Message-ID: <179482695115.3145215.5061302685838955309.b4-ty@b4> (raw)
In-Reply-To: <20261116085222.993923-1-d.csapak@proxmox.com>

On Mon, 16 Nov 2026 09:51:00 +0100, Dominik Csapak wrote:
> the resource store has a field 'diskuse' which it calculates on update.
> Use that instead of calculating the value ourselves every time.
> 
> For change detection, we only need a resolution of 0.001 (since we want
> to use the percentage with one decimal place) so check that the
> difference of old and new is at least 0.001 (0.1%).
> 
> [...]

Applied, thanks to you and Jonas for review/testing!

[1/2] ui: resource tree: use 'diskuse' instead of calculating every time
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=e5881fbbfcb99b6996985e399697f8769534b8db
[2/2] ui: resource tree: only fire 'refresh' event when something changed
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=a4261f75c6574c4350b1a415ed8b23137bf36532




      parent reply	other threads:[~2026-11-16 11:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  8:51 [PATCH pve-manager v4 1/2] ui: resource tree: use 'diskuse' instead of calculating every time Dominik Csapak
2026-11-16  8:51 ` [PATCH pve-manager v4 2/2] ui: resource tree: only fire 'refresh' event when something changed Dominik Csapak
2026-11-16 11:04 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179482695115.3145215.5061302685838955309.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=j.theisen@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal