From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id DAA5F1FF0BC for ; Mon, 16 Nov 2026 12:05:07 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3940F21721; Mon, 16 Nov 2026 12:05:03 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Dominik Csapak Subject: applied: [PATCH pve-manager v4 1/2] ui: resource tree: use 'diskuse' instead of calculating every time Date: Mon, 16 Nov 2026 12:04:50 +0100 Message-ID: <179482695115.3145215.5061302685838955309.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261116085222.993923-1-d.csapak@proxmox.com> References: <20261116085222.993923-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794827099056 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.202 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: I4JHKWVEWBV2B37SS7PQYXYNBCUT5QXD X-Message-ID-Hash: I4JHKWVEWBV2B37SS7PQYXYNBCUT5QXD X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jonas Theisen X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 16 Nov 2026 09:51:00 +0100, Dominik Csapak wrote: > the resource store has a field 'diskuse' which it calculates on update. > Use that instead of calculating the value ourselves every time. > > For change detection, we only need a resolution of 0.001 (since we want > to use the percentage with one decimal place) so check that the > difference of old and new is at least 0.001 (0.1%). > > [...] Applied, thanks to you and Jonas for review/testing! [1/2] ui: resource tree: use 'diskuse' instead of calculating every time https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=e5881fbbfcb99b6996985e399697f8769534b8db [2/2] ui: resource tree: only fire 'refresh' event when something changed https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=a4261f75c6574c4350b1a415ed8b23137bf36532