From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: applied: [PATCH manager 0/4] ui: small fixes for tag editing
Date: Fri, 6 Nov 2026 00:44:11 +0100 [thread overview]
Message-ID: <179392224842.2234121.12713934492033260760.b4-ty@b4> (raw)
In-Reply-To: <20261105125423.3788112-1-d.csapak@proxmox.com>
On Thu, 05 Nov 2026 13:53:17 +0100, Dominik Csapak wrote:
> Some small issues noticed when looking for the same issue as [0].
>
> 0: https://lore.proxmox.com/pve-devel/0c0f6a2b-b475-4f41-9342-c0d4ae94becc@inrae.fr/
>
> Dominik Csapak (4):
> ui: form: list field: don't modify the class definition
> ui: form: list field: fix type for header text assignment
> ui: dc: options: add emptytext to user tag access edit grid
> ui: dc options: add missing field title to registered tag edit grid
>
> [...]
Applied, thanks!
With some changes on top:
I squashed 4/4 into 2/4, since the typo fix is what makes the default
"Item" header visible in the first place.
3/4 now moves the empty text instead of adding a second one. The
emptyText on the list field itself is ignored, it was left behind when
56dee217b ("ui: fix datacenter tags options inputs") moved the one for
registered tags into the grid config.
I also shortened the commit messages and merged some prefix levels.
In 1/4 I dropped the "alternating": opening Registered Tags once is
enough for User Tag Access to also show the empty text until the next
page reload.
[1/4] ui: form: list field: don't modify the class definition
https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=7520a9b701607ba8a489e50fc61180784947c1f5
[2/4] ui: form: list field: fix type for header text assignment
https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=8eaa8a7406bd9f25177141f277d84f97b9033b0e
[3/4] ui: dc: options: add emptytext to user tag access edit grid
https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=9cc05ac0b47b9ffd383b7de016f4445b17d9bdd0
[4/4] ui: dc options: add missing field title to registered tag edit grid
https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=8eaa8a7406bd9f25177141f277d84f97b9033b0e
prev parent reply other threads:[~2026-11-06 21:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 12:53 [PATCH manager 0/4] ui: small fixes for tag editing Dominik Csapak
2026-11-05 12:53 ` [PATCH manager 1/4] ui: form: list field: don't modify the class definition Dominik Csapak
2026-11-05 12:53 ` [PATCH manager 2/4] ui: form: list field: fix type for header text assignment Dominik Csapak
2026-11-05 12:53 ` [PATCH manager 3/4] ui: dc: options: add emptytext to user tag access edit grid Dominik Csapak
2026-11-05 12:53 ` [PATCH manager 4/4] ui: dc options: add missing field title to registered tag " Dominik Csapak
2026-11-05 23:44 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179392224842.2234121.12713934492033260760.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox