From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id A0DB71FF0AF for ; Fri, 06 Nov 2026 22:10:29 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 1DF152162B; Fri, 06 Nov 2026 22:10:25 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Dominik Csapak Subject: applied: [PATCH manager 0/4] ui: small fixes for tag editing Date: Fri, 6 Nov 2026 00:44:11 +0100 Message-ID: <179392224842.2234121.12713934492033260760.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261105125423.3788112-1-d.csapak@proxmox.com> References: <20261105125423.3788112-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793999414638 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.120 Adjusted score from AWL reputation of From: address DATE_IN_PAST_12_24 0.804 Date: is 12 to 24 hours before Received: date DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LRZGENQGQ45LWQDRUS6ECD5TD4D4BHBT X-Message-ID-Hash: LRZGENQGQ45LWQDRUS6ECD5TD4D4BHBT X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 05 Nov 2026 13:53:17 +0100, Dominik Csapak wrote: > Some small issues noticed when looking for the same issue as [0]. > > 0: https://lore.proxmox.com/pve-devel/0c0f6a2b-b475-4f41-9342-c0d4ae94becc@inrae.fr/ > > Dominik Csapak (4): > ui: form: list field: don't modify the class definition > ui: form: list field: fix type for header text assignment > ui: dc: options: add emptytext to user tag access edit grid > ui: dc options: add missing field title to registered tag edit grid > > [...] Applied, thanks! With some changes on top: I squashed 4/4 into 2/4, since the typo fix is what makes the default "Item" header visible in the first place. 3/4 now moves the empty text instead of adding a second one. The emptyText on the list field itself is ignored, it was left behind when 56dee217b ("ui: fix datacenter tags options inputs") moved the one for registered tags into the grid config. I also shortened the commit messages and merged some prefix levels. In 1/4 I dropped the "alternating": opening Registered Tags once is enough for User Tag Access to also show the empty text until the next page reload. [1/4] ui: form: list field: don't modify the class definition https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=7520a9b701607ba8a489e50fc61180784947c1f5 [2/4] ui: form: list field: fix type for header text assignment https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=8eaa8a7406bd9f25177141f277d84f97b9033b0e [3/4] ui: dc: options: add emptytext to user tag access edit grid https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=9cc05ac0b47b9ffd383b7de016f4445b17d9bdd0 [4/4] ui: dc options: add missing field title to registered tag edit grid https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=8eaa8a7406bd9f25177141f277d84f97b9033b0e