From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Fiona Ebner <f.ebner@proxmox.com>
Subject: applied: [PATCH qemu-server] tree-wide: properly adapt all version_cmp() calls to moved helper
Date: Tue, 3 Nov 2026 13:32:34 +0100 [thread overview]
Message-ID: <179370915219.1560254.12786716504031023307.b4-ty@b4> (raw)
In-Reply-To: <20261103095100.41582-1-f.ebner@proxmox.com>
On Tue, 03 Nov 2026 10:48:41 +0100, Fiona Ebner wrote:
> While commit 47c17885 ("helpers: drop local version helpers in favor
> of pve-common") works, because it explicitly imports version_cmp into
> the QemuServer::Helpers module, its intention is to switch over the
> helpers. Avoid the indirection as well as the duplicate PVE::Tools
> include in the QemuServer::Helpers module.
>
>
> [...]
Applied, thanks!
[1/1] tree-wide: properly adapt all version_cmp() calls to moved helper
https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=42176bad567e46d9c216d4df67207cd8ceb39176
prev parent reply other threads:[~2026-11-03 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 9:48 [PATCH qemu-server] tree-wide: properly adapt all version_cmp() calls to moved helper Fiona Ebner
2026-11-03 12:32 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179370915219.1560254.12786716504031023307.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox