From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id 8FFA81FF0AA
	for <inbox@lore.proxmox.com>; Tue, 03 Nov 2026 13:32:51 +0100 (CET)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 075D421852;
	Tue, 03 Nov 2026 13:32:49 +0100 (CET)
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com,
	Fiona Ebner <f.ebner@proxmox.com>
Subject: applied: [PATCH qemu-server] tree-wide: properly adapt all
 version_cmp() calls to moved helper
Date: Tue,  3 Nov 2026 13:32:34 +0100
Message-ID: <179370915219.1560254.12786716504031023307.b4-ty@b4>
X-Mailer: git-send-email 2.47.3
In-Reply-To: <20261103095100.41582-1-f.ebner@proxmox.com>
References: <20261103095100.41582-1-f.ebner@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1793709163556
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.342 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: GDQID2TBKBI6VDVPICONHPEO5Q62EDQ6
X-Message-ID-Hash: GDQID2TBKBI6VDVPICONHPEO5Q62EDQ6
X-MailFrom: t.lamprecht@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Tue, 03 Nov 2026 10:48:41 +0100, Fiona Ebner wrote:
> While commit 47c17885 ("helpers: drop local version helpers in favor
> of pve-common") works, because it explicitly imports version_cmp into
> the QemuServer::Helpers module, its intention is to switch over the
> helpers. Avoid the indirection as well as the duplicate PVE::Tools
> include in the QemuServer::Helpers module.
> 
> 
> [...]

Applied, thanks!

[1/1] tree-wide: properly adapt all version_cmp() calls to moved helper
      https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=42176bad567e46d9c216d4df67207cd8ceb39176