public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Elias Huhsovitz <e.huhsovitz@proxmox.com>
Subject: applied: [PATCH proxmox-perl-rs v2 0/3] makefile: reduce ambiguity for targets: all/install/upload
Date: Tue,  3 Nov 2026 01:01:21 +0100	[thread overview]
Message-ID: <179366407991.2376650.10770167397646741326.b4-ty@b4> (raw)
In-Reply-To: <20261030132533.150795-1-e.huhsovitz@proxmox.com>

On Fri, 30 Oct 2026 14:25:30 +0100, Elias Huhsovitz wrote:
> I encounted some minor inconsistencies in the Makefile:
> * make install only installs from release dir (Even though 'make all'
>   generates a debug build per default)
> * File Fixup.pm is used inside a target but not specified as a
>   prerequisite.
> * unsued variable for upload target.
> 
> [...]

Applied, thanks!

[1/3] makefile: use TARGET_DIR variable for install target
      commit: 36b4ef9c65e5d8dcc385d625ae9c3909d0fd31f3
[2/3] makefile: add Fixup.pm as prerequisite for $(BUILDDIR)
      commit: 9ca4005750a48b87c35b5b1ba595e59e1aebd95e
[3/3] makefile: use UPLOAD_DIST variable
      commit: f5dc49f50dbcd27aa3b7b8b8a266caa7162ed900




      parent reply	other threads:[~2026-11-03  0:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-30 13:25 [PATCH proxmox-perl-rs v2 0/3] makefile: reduce ambiguity for targets: all/install/upload Elias Huhsovitz
2026-10-30 13:25 ` [PATCH proxmox-perl-rs v2 1/3] makefile: use TARGET_DIR variable for install target Elias Huhsovitz
2026-10-30 13:25 ` [PATCH proxmox-perl-rs v2 2/3] makefile: add Fixup.pm as prerequisite for $(BUILDDIR) Elias Huhsovitz
2026-10-30 13:25 ` [PATCH proxmox-perl-rs v2 3/3] makefile: use UPLOAD_DIST variable Elias Huhsovitz
2026-11-03  0:01 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179366407991.2376650.10770167397646741326.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=e.huhsovitz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal