From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Mark Atwood <mark@wolfssl.com>
Subject: applied: [PATCH access-control] csrf: drop leftover SHA-1 token fallback
Date: Mon, 2 Nov 2026 23:38:51 +0100 [thread overview]
Message-ID: <179365912543.1964005.17770288522354055180.b4-ty@b4> (raw)
In-Reply-To: <20261023185755.541328-1-mark@wolfssl.com>
On Fri, 23 Oct 2026 11:57:55 -0700, Mark Atwood wrote:
> verify_csrf_prevention_token still derives a SHA-1 based secret from the
> www key and switches to it for tokens with a 27 character signature, as
> issued by PVE 5 and older.
>
> This fallback stopped working when pve-common commit ff39327 ("ticket:
> remove fallback for SHA1-base64 CSRF prevention tokens") made
> PVE::Ticket::verify_csrf_prevention_token always compute an
> HMAC-SHA-256, whose 43 character signature can never match a 27
> character one. Such tokens are therefore rejected either way, and the
> build dependency on libpve-common-perl (>= 9.1.11) already pulls in that
> change.
>
> [...]
Applied, thanks!
[1/1] csrf: drop leftover SHA-1 token fallback
commit: 07bb3b129ca91300087b937201280d2a11e54680
prev parent reply other threads:[~2026-11-02 22:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 18:57 [PATCH access-control] csrf: drop leftover SHA-1 token fallback Mark Atwood
2026-11-02 14:06 ` Shannon Sterz
2026-11-02 22:38 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179365912543.1964005.17770288522354055180.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=mark@wolfssl.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox