From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id 18DD51FF0F5
	for <inbox@lore.proxmox.com>; Mon, 02 Nov 2026 23:39:09 +0100 (CET)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 138FC2172E;
	Mon, 02 Nov 2026 23:39:05 +0100 (CET)
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com,
	Mark Atwood <mark@wolfssl.com>
Subject: applied: [PATCH access-control] csrf: drop leftover SHA-1 token
 fallback
Date: Mon,  2 Nov 2026 23:38:51 +0100
Message-ID: <179365912543.1964005.17770288522354055180.b4-ty@b4>
X-Mailer: git-send-email 2.47.3
In-Reply-To: <20261023185755.541328-1-mark@wolfssl.com>
References: <20261023185755.541328-1-mark@wolfssl.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1793659139264
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.358 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: BLKAZUSEQVWIVLSEJVPSHH74EGHZBLT7
X-Message-ID-Hash: BLKAZUSEQVWIVLSEJVPSHH74EGHZBLT7
X-MailFrom: t.lamprecht@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Fri, 23 Oct 2026 11:57:55 -0700, Mark Atwood wrote:
> verify_csrf_prevention_token still derives a SHA-1 based secret from the
> www key and switches to it for tokens with a 27 character signature, as
> issued by PVE 5 and older.
> 
> This fallback stopped working when pve-common commit ff39327 ("ticket:
> remove fallback for SHA1-base64 CSRF prevention tokens") made
> PVE::Ticket::verify_csrf_prevention_token always compute an
> HMAC-SHA-256, whose 43 character signature can never match a 27
> character one. Such tokens are therefore rejected either way, and the
> build dependency on libpve-common-perl (>= 9.1.11) already pulls in that
> change.
> 
> [...]

Applied, thanks!

[1/1] csrf: drop leftover SHA-1 token fallback
      commit: 07bb3b129ca91300087b937201280d2a11e54680