[PATCH container] fix #8237: delete read restricted options: fix calls to check_vm_perm

[PATCH container] fix #8237: delete read restricted options: fix calls to check_vm_perm

[Fiona Ebner]

The checks are supposed to pass $noerr=1, but instead passed $any=1.
Therefore, GET requests for '/config' and '/pending' by a user without
'VM.Config.Options' would fail for containers with 'env' set instead
of deleting the key from the result.

Fixes: 9ec1a04 ("api: config: censor env property for users without VM.Config.Options")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/LXC.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 44ae4fa..4afa391 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -1639,7 +1639,7 @@ sub delete_read_restricted_options {
     for my ($restricted_key, $required_priv) ($options_with_restricted_read->%*) {
         my $has_no_access = 0;
         if (exists($conf->{$restricted_key})) {
-            if (!$rpcenv->check_vm_perm($authuser, $vmid, $pool, [$required_priv], 1)) {
+            if (!$rpcenv->check_vm_perm($authuser, $vmid, $pool, [$required_priv], undef, 1)) {
                 $has_no_access = 1;
                 delete $conf->{$restricted_key};
             }
@@ -1647,7 +1647,7 @@ sub delete_read_restricted_options {
         if (exists($conf->{pending}) && exists($conf->{pending}->{$restricted_key})) {
             if (
                 $has_no_access
-                || !$rpcenv->check_vm_perm($authuser, $vmid, $pool, [$required_priv], 1)
+                || !$rpcenv->check_vm_perm($authuser, $vmid, $pool, [$required_priv], undef, 1)
             ) {
                 delete $conf->{pending}->{$restricted_key};
             }
-- 
2.47.3

applied: [PATCH container] fix #8237: delete read restricted options: fix calls to check_vm_perm

[Thomas Lamprecht]

On Thu, 29 Oct 2026 11:30:51 +0100, Fiona Ebner wrote:
> The checks are supposed to pass $noerr=1, but instead passed $any=1.
> Therefore, GET requests for '/config' and '/pending' by a user without
> 'VM.Config.Options' would fail for containers with 'env' set instead
> of deleting the key from the result.

Applied, thanks!

[1/1] fix #8237: delete read restricted options: fix calls to check_vm_perm
      commit: 2b415bfe379f3fadb3fdd1e643a09e504fc7a049