* [PATCH qemu-server] clone: drop the IPAM entries of a clone that failed
@ 2026-08-19 13:51 Hannes Laimer
2026-10-28 15:10 ` applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Laimer @ 2026-08-19 13:51 UTC (permalink / raw)
To: pve-devel
The clone puts its addresses on record before the last steps that can
still fail, and the cleanup afterwards took back the disks, the firewall
config and the configuration itself but left those behind.
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
src/PVE/API2/Qemu.pm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
index 71247eec..b17f9bce 100644
--- a/src/PVE/API2/Qemu.pm
+++ b/src/PVE/API2/Qemu.pm
@@ -4720,6 +4720,9 @@ __PACKAGE__->register_method({
warn $@ if $@;
}
+ eval { PVE::QemuServer::Network::delete_ifaces_ipams_ips($newconf, $newid) };
+ warn $@ if $@;
+
PVE::Firewall::remove_vmfw_conf($newid);
unlink $conffile; # avoid races -> last thing before die
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* applied: [PATCH qemu-server] clone: drop the IPAM entries of a clone that failed
2026-08-19 13:51 [PATCH qemu-server] clone: drop the IPAM entries of a clone that failed Hannes Laimer
@ 2026-10-28 15:10 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2026-10-28 15:10 UTC (permalink / raw)
To: pve-devel, Hannes Laimer
On Wed, 19 Aug 2026 15:51:20 +0200, Hannes Laimer wrote:
> The clone puts its addresses on record before the last steps that can
> still fail, and the cleanup afterwards took back the disks, the firewall
> config and the configuration itself but left those behind.
Applied, thanks!
[1/1] clone: drop the IPAM entries of a clone that failed
https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=8d435c5bdb711f776ddbcc116a390e3128e11061
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-28 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-19 13:51 [PATCH qemu-server] clone: drop the IPAM entries of a clone that failed Hannes Laimer
2026-10-28 15:10 ` applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox