From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Elias Huhsovitz <e.huhsovitz@proxmox.com>
Subject: applied: [PATCH storage 0/3] generalize volname_for_format across storage plugins
Date: Sun, 4 Oct 2026 21:33:28 +0200 [thread overview]
Message-ID: <179114230692.2862530.15975723078503191367.b4-ty@b4> (raw)
In-Reply-To: <20260812153252.222298-1-e.huhsovitz@proxmox.com>
On Wed, 12 Aug 2026 17:32:49 +0200, Elias Huhsovitz wrote:
> Previously, only the LVM plugin explicitly validated that a requested
> volume format matched the provided volume name. This inconsistency
> allowed other storage backends to silently accept mismatched names and
> formats, leading to confusing states (as was previously mentioned in
> bug #7811).
>
> Centralize volname_for_format() in the base PVE::Storage::Plugin.
> This design allows individual plugins to override specific parsing
> behavior while sharing the core validation logic.
>
> [...]
Applied, thanks!
[1/3] plugin: refactor format parsing in parse_volname and parse_name_dir
(no commit info)
[2/3] plugin: generalize volname_for_format across storage plugins
https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=3d50f58bc813546c5fa06e9634d80abd0584e01d
[3/3] test: plugin: add unit tests for volname_for_format
https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=81cf3c78f12f1915365c2598a69b56b5f966b9f7
prev parent reply other threads:[~2026-10-04 19:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 15:32 [PATCH storage 0/3] generalize volname_for_format across storage plugins Elias Huhsovitz
2026-08-12 15:32 ` [PATCH storage 1/3] plugin: refactor format parsing in parse_volname and parse_name_dir Elias Huhsovitz
2026-08-12 15:32 ` [PATCH storage 2/3] plugin: generalize volname_for_format across storage plugins Elias Huhsovitz
2026-08-12 15:32 ` [PATCH storage 3/3] test: plugin: add unit tests for volname_for_format Elias Huhsovitz
2026-10-04 19:33 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179114230692.2862530.15975723078503191367.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=e.huhsovitz@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox