[PATCH storage 1/3] plugin: refactor format parsing in parse_volname and parse_name_dir

[Elias Huhsovitz <e.huhsovitz@proxmox.com>]

Previously, `parse_volname` in several plugins (LVM, LvmThin, RBD)
hardcoded the returned format to 'raw', ignoring any format extension
present in the volume name. This prevented the detection of mismatched
formats, such as passing a `.qcow2` name to a raw-only storage.

Update `parse_volname` in `LVMPlugin`, `LvmThinPlugin`, and `RBDPlugin`
to dynamically extract the format from the volume name extension (e.g.,
`.raw`, `.qcow2`, `.vmdk`, `.subvol`), falling back to 'raw' if no known
extension is present.

Ajust `parse_name_dir` in `Plugin.pm` to allow parsing of names without
an extension, returning 'raw' as the default format. This prepares the
base class for extension-less volume names used by block storages.

Signed-off-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
---
 src/PVE/Storage/LVMPlugin.pm     | 2 +-
 src/PVE/Storage/LvmThinPlugin.pm | 6 +++++-
 src/PVE/Storage/Plugin.pm        | 2 ++
 src/PVE/Storage/RBDPlugin.pm     | 8 +++++++-
 4 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm
index 67ba0f7..0f2ef66 100644
--- a/src/PVE/Storage/LVMPlugin.pm
+++ b/src/PVE/Storage/LVMPlugin.pm
@@ -526,7 +526,7 @@ sub parse_volname {
     if ($volname =~ m/^(vm-(\d+)-\S+)$/) {
         my $name = $1;
         my $vmid = $2;
-        my $format = $volname =~ m/\.qcow2$/ ? 'qcow2' : 'raw';
+        my $format = ($volname =~ m/\.(raw|qcow2|vmdk|subvol)$/) ? $1 : 'raw';
         return ('images', $name, $vmid, undef, undef, undef, $format);
     }
 
diff --git a/src/PVE/Storage/LvmThinPlugin.pm b/src/PVE/Storage/LvmThinPlugin.pm
index cadf343..d44e04d 100644
--- a/src/PVE/Storage/LvmThinPlugin.pm
+++ b/src/PVE/Storage/LvmThinPlugin.pm
@@ -66,7 +66,11 @@ sub parse_volname {
     PVE::Storage::Plugin::parse_lvm_name($volname);
 
     if ($volname =~ m/^((vm|base)-(\d+)-\S+)$/) {
-        return ('images', $1, $3, undef, undef, $2 eq 'base', 'raw');
+        my $name = $1;
+        my $isbase = $2 eq 'base';
+        my $vmid = $3;
+        my $format = ($volname =~ m/\.(raw|qcow2|vmdk|subvol)$/) ? $1 : 'raw';
+        return ('images', $name, $vmid, undef, undef, $isbase, $format);
     }
 
     die "unable to parse lvm volume name '$volname'\n";
diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
index 4f69f9b..c5046a4 100644
--- a/src/PVE/Storage/Plugin.pm
+++ b/src/PVE/Storage/Plugin.pm
@@ -789,6 +789,8 @@ sub parse_name_dir {
         return ($1, $4, $isbase); # (name, format, isBase)
     } elsif ($name =~ m!^snap-.*\.qcow2$!) {
         die "'$name' is a snapshot filename, not a volume!\n";
+    } elsif ($name =~ m!^((base-)?[^/\s]+)$!) {
+        return ($1, 'raw', $2); # (name, format, isBase)
     } elsif ($name =~ m!^((base-)?[^/\s]+\.(raw|qcow2|vmdk|subvol))$!) {
         return ($1, $3, $2); # (name ,format, isBase)
     }
diff --git a/src/PVE/Storage/RBDPlugin.pm b/src/PVE/Storage/RBDPlugin.pm
index b537425..8ebb999 100644
--- a/src/PVE/Storage/RBDPlugin.pm
+++ b/src/PVE/Storage/RBDPlugin.pm
@@ -510,7 +510,13 @@ sub parse_volname {
     my ($class, $volname) = @_;
 
     if ($volname =~ m/^((base-(\d+)-\S+)\/)?((base)?(vm)?-(\d+)-\S+)$/) {
-        return ('images', $4, $7, $2, $3, $5, 'raw');
+        my $basename = $2;
+        my $basevmid = $3;
+        my $name = $4;
+        my $isbase = $5;
+        my $vmid = $7;
+        my $format = ($volname =~ m/\.(raw|qcow2|vmdk|subvol)$/) ? $1 : 'raw';
+        return ('images', $name, $vmid, $basename, $basevmid, $isbase, $format);
     }
 
     die "unable to parse rbd volume name '$volname'\n";
-- 
2.47.3