From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com, Michal Fox <me@dualfroz.com>
Subject: applied: [PATCH manager] fix #7108: ui: ipset: do not offer aliases that are already added
Date: Wed, 30 Sep 2026 12:27:55 +0200 [thread overview]
Message-ID: <179076404147.1629239.15364462673749557816.b4-ty@b4> (raw)
In-Reply-To: <20260929142331.2990690-1-me@dualfroz.com>
On Tue, 29 Sep 2026 16:23:31 +0200, Michal Fox wrote:
> When adding an entry to an IPSet, the alias selector lists all aliases,
> including those that are already part of the IPSet. Selecting one of
> them only results in an "already exists" error from the API.
>
> Pass the current entries of the IPSet to the add window and filter the
> matching aliases out of the selector. Aliases are stored in the IPSet
> with the same scoped reference the selector uses as value, so an exact
> comparison is sufficient.
>
> [...]
Applied, thanks!
[1/1] fix #7108: ui: ipset: do not offer aliases that are already added
commit: 8efee570fbe9b99df40daf6ab83d77db295379cb
prev parent reply other threads:[~2026-09-30 10:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 14:23 [PATCH manager] fix #7108: ui: ipset: do not offer aliases that are already added Michal Fox
2026-09-30 9:50 ` Arthur Bied-Charreton
2026-09-30 10:27 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179076404147.1629239.15364462673749557816.b4-ty@b4 \
--to=d.csapak@proxmox.com \
--cc=me@dualfroz.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox