From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id D0C821FF0C4 for ; Wed, 30 Sep 2026 12:28:26 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3328321641; Wed, 30 Sep 2026 12:28:24 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com, Michal Fox Subject: applied: [PATCH manager] fix #7108: ui: ipset: do not offer aliases that are already added Date: Wed, 30 Sep 2026 12:27:55 +0200 Message-ID: <179076404147.1629239.15364462673749557816.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260929142331.2990690-1-me@dualfroz.com> References: <20260929142331.2990690-1-me@dualfroz.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.423 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZIKIZXRYVYG3H4HPNVSUQRFW7T54EDD4 X-Message-ID-Hash: ZIKIZXRYVYG3H4HPNVSUQRFW7T54EDD4 X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 29 Sep 2026 16:23:31 +0200, Michal Fox wrote: > When adding an entry to an IPSet, the alias selector lists all aliases, > including those that are already part of the IPSet. Selecting one of > them only results in an "already exists" error from the API. > > Pass the current entries of the IPSet to the add window and filter the > matching aliases out of the selector. Aliases are stored in the IPSet > with the same scoped reference the selector uses as value, so an exact > comparison is sufficient. > > [...] Applied, thanks! [1/1] fix #7108: ui: ipset: do not offer aliases that are already added commit: 8efee570fbe9b99df40daf6ab83d77db295379cb