Re: [PATCH common/manager/proxmox-widget-toolkit/storage/storage-plugin-examples v3 00/17] GUI Support for Custom Storage Plugins

[Alfonso Kuen <gerencia@idkmanager.com>]

Hi Max,

I gave v3 a spin with a real third-party plugin, the TrueNAS storage
plugin (iSCSI and NVMe/TCP, PVE::Storage::Custom::TrueNASPlugin), on a
single-node PVE 9.2 test host.

Setup: the 17 patches applied cleanly with git am on pve-common
9943f6f, pve-storage 9b5a5a5, proxmox-widget-toolkit 5faa913 and
pve-manager 122efff2. Building the widget toolkit needed
proxmox-biome, which is not in pve-no-subscription yet; I built it
from git.proxmox.com, which in turn needed rustc/cargo from
trixie-backports (the 1.85 in trixie is too old for one of the
vendored crates).

On the plugin side I only added a `title` to each of its 46
properties and an 'advanced-properties' hash (23 tuning knobs) - not a
line of JavaScript. What I checked:

- The type shows up in Datacenter -> Storage -> Add next to the
  built-in ones, and the form is built from the schema with the titles.
- Its four 'sensitive-properties' (API key, CHAP password, two NVMe
  DH-HMAC-CHAP secrets) render as password fields and show
  "Unchanged" on edit, never the stored value.
- The advanced knobs stay behind the Advanced toggle.
- `fixed` properties are editable on create and display-only on edit.
- Add and edit round-trip through the API with the secrets ending up
  in the plugin's /etc/pve/priv files, not in storage.cfg.

I didn't hit any problem with this plugin beyond what Thomas already
reported.

One thought for later rather than for this series: the next gap for
a plugin like this one is operational rather than configuration -
per-volume actions and plugin-specific commands (for us, adopting
snapshots taken on the array into the guest config). Some way for a
plugin to declare such actions would round this out nicely.

Tested-by: Alfonso Kuen <gerencia@idkmanager.com>

Thanks for the work on this.

Alfonso