From: "Jakob Klocker" <j.klocker@proxmox.com>
To: "Jakob Klocker" <j.klocker@proxmox.com>,
"Max R. Carrara" <m.carrara@proxmox.com>,
<pve-devel@lists.proxmox.com>
Subject: Re: [PATCH common/manager/proxmox-widget-toolkit/storage/storage-plugin-examples v3 00/17] GUI Support for Custom Storage Plugins
Date: Mon, 03 Aug 2026 15:27:36 +0200 [thread overview]
Message-ID: <DKFCDUOVOYDG.XZOJQX4F9U6K@proxmox.com> (raw)
In-Reply-To: <DKFABGUHM6IU.3FDYMNEV2ZA3U@proxmox.com>
On Mon Aug 3, 2026 at 1:50 PM CEST, Jakob Klocker wrote:
> I ran the same tests as in the previous version:
>
> - adding sshfs plugin over the GUI
> - editing a plugin over the GUI
> - removing a plugin over the GUI
To clarify the above: I meant adding/editing/removing a storage of type
sshfs via the GUI, not the plugin itself.
> - checking the output of the new endpoints
>
> everything worked as expected.
>
> With the changes from the previous versions the code looks good to me.
> Note that I don't have that much experience with the frontend, but
> from what I can tell everything looks good.
>
> A small side note: there isn't a unified Makefile style across the
> codebase, which would make sense to have.
>
> With that said, thanks for the patches and consider this:
>
> Reviewed-by: Jakob Klocker <j.klocker@proxmox.com>
> Tested-by: Jakob Klocker <j.klocker@proxmox.com>
> On Mon Jul 27, 2026 at 4:34 PM CEST, Max R. Carrara wrote:
>> GUI Support for Custom Storage Plugins - v3
>> ===========================================
>>
>> Notable Changes Since v2
>> ------------------------
>>
>> [SNIP]
next prev parent reply other threads:[~2026-08-03 13:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 14:34 [PATCH common/manager/proxmox-widget-toolkit/storage/storage-plugin-examples v3 00/17] GUI Support for Custom Storage Plugins Max R. Carrara
2026-07-27 14:34 ` [PATCH pve-common v3 01/17] json schema: add multiline string format Max R. Carrara
2026-07-27 14:34 ` [PATCH pve-storage v3 02/17] api: plugins/storage: add initial routes and endpoints Max R. Carrara
2026-07-27 14:34 ` [PATCH pve-storage v3 03/17] api: plugins/storage/plugin: include schema in plugin metadata Max R. Carrara
2026-07-27 14:34 ` [PATCH pve-storage v3 04/17] api: plugins/storage/plugin: mark sensitive properties in schema Max R. Carrara
2026-07-27 14:34 ` [PATCH pve-storage v3 05/17] api: plugins/storage/plugin: factor plugin metadata code into helper Max R. Carrara
2026-07-27 14:34 ` [PATCH pve-storage v3 06/17] api: plugins/storage/plugin: add plugins' 'content' to their metadata Max R. Carrara
2026-07-27 14:34 ` [PATCH pve-storage v3 07/17] all plugins: add 'title' to properties, adapt 'description's Max R. Carrara
2026-07-27 14:34 ` [PATCH pve-storage v3 08/17] all plugins, api: mark certain properties as advanced in plugindata() Max R. Carrara
2026-07-27 14:34 ` [PATCH pve-storage v3 09/17] all plugins, api: mark certain properties as hidden " Max R. Carrara
2026-07-27 14:34 ` [PATCH proxmox-widget-toolkit v3 10/17] form: introduce new 'proxmoxtextarea' field Max R. Carrara
2026-07-27 14:34 ` [PATCH proxmox-widget-toolkit v3 11/17] utils: introduce helper function getFieldDefFromPropertySchema Max R. Carrara
2026-07-27 14:34 ` [PATCH proxmox-widget-toolkit v3 12/17] acme: use helper to construct ExtJS fields from property schemas Max R. Carrara
2026-07-27 14:34 ` [PATCH pve-manager v3 13/17] api2: sort modules and API method registrations Max R. Carrara
2026-07-27 14:34 ` [PATCH pve-manager v3 14/17] api: add API routes 'plugins' and 'plugins/storage' Max R. Carrara
2026-07-27 14:34 ` [PATCH pve-manager v3 15/17] ui: storage view: display error when no editor for storage type exists Max R. Carrara
2026-07-27 14:34 ` [PATCH pve-manager v3 16/17] ui: storage: add basic UI integration for custom storage plugins Max R. Carrara
2026-07-27 14:34 ` [PATCH pve-storage-plugin-examples v3 17/17] sshfs: Update SSHFS plugin Max R. Carrara
2026-08-03 11:50 ` [PATCH common/manager/proxmox-widget-toolkit/storage/storage-plugin-examples v3 00/17] GUI Support for Custom Storage Plugins Jakob Klocker
2026-08-03 13:27 ` Jakob Klocker [this message]
2026-08-04 10:40 ` Thomas Ellmenreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKFCDUOVOYDG.XZOJQX4F9U6K@proxmox.com \
--to=j.klocker@proxmox.com \
--cc=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox