public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Ilan Karasik <ilankarasik@gmail.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH v2] fix #7571: emit mtu in ifupdown-based LXC guests
Date: Mon, 07 Sep 2026 16:04:35 +0200	[thread overview]
Message-ID: <1788789833.n8xgk28l2s.astroid@yuna.none> (raw)
In-Reply-To: <20260617183228.95036-2-ilankarasik@gmail.com>

On June 17, 2026 8:32 pm, Ilan Karasik wrote:
> This fixes a bug where custom mtu settings applied to an LXC container
> are silently ignored during network setup for Debian-based guests
> using ifupdown.
> 
> Because the Proxmox network setup was failing to write the mtu value
> to the guest's `/etc/network/interfaces` file, the container would
> always default to an mtu of 1500.
> 
> This patch resolves the issue by writing the `mtu <value>` directive into the
> guest's network configuration file at /etc/network/interfaces.
> 
> Signed-off-by: Ilan Karasik <ilankarasik@gmail.com>
> ---
>  src/PVE/LXC/Setup/Debian.pm | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/PVE/LXC/Setup/Debian.pm b/src/PVE/LXC/Setup/Debian.pm
> index 837397b..bbf73d5 100644
> --- a/src/PVE/LXC/Setup/Debian.pm
> +++ b/src/PVE/LXC/Setup/Debian.pm
> @@ -284,6 +284,7 @@ sub setup_network {
>                      $net->{needsroute6} = 1;
>                  }
>              }
> +            $net->{mtu} = $d->{mtu} if defined($d->{mtu});
>              $networks->{ $d->{name} } = $net if keys %$net;
>          }
>      }
> @@ -337,6 +338,7 @@ sub setup_network {
>                          $interfaces .= "\tgateway $gw\n";
>                      }
>                  }
> +                $interfaces .= "\tmtu $net->{mtu}\n" if defined($net->{mtu});

sorry for the long turnaround time!

should we also set this higher up in the dhcp/manual part?

>                  foreach my $attr (@{ $section->{attr} }) {
>                      $interfaces .= "\t$attr\n";
>                  }
> @@ -450,6 +452,7 @@ sub setup_network {
>                      || $aname eq 'netmask'
>                      || $aname eq 'gateway'
>                      || $aname eq 'broadcast'
> +                    || $aname eq 'mtu'
>                  ) {
>                      # skip
>                  } else {
> -- 
> 2.51.2
> 
> 
> 
> 
> 




  reply	other threads:[~2026-09-07 14:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06 23:00 [PATCH pve-container] fix #7571: emit mtu in ifupdown-based LXC guests Ilan Karasik
2026-06-16 10:22 ` Fabian Grünbichler
2026-06-17 18:32   ` [PATCH v2] " Ilan Karasik
2026-09-07 14:04     ` Fabian Grünbichler [this message]
2026-09-07 15:39       ` [PATCH v3] " Ilan Karasik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1788789833.n8xgk28l2s.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=ilankarasik@gmail.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal