public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Ilan Karasik <ilankarasik@gmail.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-container] fix #7571: emit mtu in ifupdown-based LXC guests
Date: Tue, 16 Jun 2026 12:22:06 +0200	[thread overview]
Message-ID: <1781605179.y4iy928e70.astroid@yuna.none> (raw)
In-Reply-To: <20260506230002.36906-1-ilankarasik@gmail.com>

Hi!

please see https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright
for our CLA requirements, and send a signed copy as instructed there.

On May 7, 2026 1:00 am, Ilan Karasik wrote:
> From: iamkarasik <ilankarasik@gmail.com>

please add a short description of the commit/patch here, see our
developer documentation for details:

> Do not put in a literal description of the code diff, especially not
> for simpler changes. The commit message should not focus on the
> detailed what's done/changed but rather answer:
>
>    Why this was done otherwise previously (or why this was missing
>    until now).
>
>    Why the new approach is better or necessary (e.g., a
>    bug was found, requirements changed, a prerequisite was merged that
>    enables this).
>
>    What the resulting effect is for users or developers
>    (if not already obvious from the subject line). If there should be
>    no visible/semantic change then explicitly stating so can also be
>    good for non-trivial changes.

Thanks!

> 
> Signed-off-by: iamkarasik <ilankarasik@gmail.com>
> ---
>  src/PVE/LXC/Setup/Debian.pm | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/PVE/LXC/Setup/Debian.pm b/src/PVE/LXC/Setup/Debian.pm
> index 837397b..bbf73d5 100644
> --- a/src/PVE/LXC/Setup/Debian.pm
> +++ b/src/PVE/LXC/Setup/Debian.pm
> @@ -284,6 +284,7 @@ sub setup_network {
>                      $net->{needsroute6} = 1;
>                  }
>              }
> +            $net->{mtu} = $d->{mtu} if defined($d->{mtu});
>              $networks->{ $d->{name} } = $net if keys %$net;
>          }
>      }
> @@ -337,6 +338,7 @@ sub setup_network {
>                          $interfaces .= "\tgateway $gw\n";
>                      }
>                  }
> +                $interfaces .= "\tmtu $net->{mtu}\n" if defined($net->{mtu});
>                  foreach my $attr (@{ $section->{attr} }) {
>                      $interfaces .= "\t$attr\n";
>                  }
> @@ -450,6 +452,7 @@ sub setup_network {
>                      || $aname eq 'netmask'
>                      || $aname eq 'gateway'
>                      || $aname eq 'broadcast'
> +                    || $aname eq 'mtu'
>                  ) {
>                      # skip
>                  } else {
> -- 
> 2.51.2
> 
> 
> 
> 
> 




      reply	other threads:[~2026-06-16 10:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06 23:00 [PATCH pve-container] fix #7571: emit mtu in ifupdown-based LXC guests Ilan Karasik
2026-06-16 10:22 ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1781605179.y4iy928e70.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=ilankarasik@gmail.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal