public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH qemu-server] fix #7981: cpu flags: Hyper-V enlightenments on x86_64 only
@ 2026-08-31 10:17 Erik Fastermann
  2026-09-03 13:32 ` applied: " Fiona Ebner
  0 siblings, 1 reply; 2+ messages in thread
From: Erik Fastermann @ 2026-08-31 10:17 UTC (permalink / raw)
  To: pve-devel; +Cc: Erik Fastermann

'hv-passthrough' is x86-only, so QEMU's ARM target rejects it with
"Parameter 'model.props.hv-passthrough' is unexpected". The whole
expansion then fails, leaving pvestatd unable to populate the
cpuflags-kvm node key on aarch64 hosts. Guard with the arch to prevent
this.

Fixes: 698550c2 ("cpu flags: include Hyper-V enlightenment flags in supported flags")

Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
---
 src/PVE/QemuServer.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index 63d8c135..0e3ab288 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -3023,7 +3023,7 @@ sub query_supported_cpu_flags {
         die "QEMU flag querying VM exited with code " . $rc if $rc;
 
         my $model = { name => $kvm ? 'host' : 'max' };
-        $model->{props} = { 'hv-passthrough' => JSON::true } if $kvm;
+        $model->{props} = { 'hv-passthrough' => JSON::true } if $kvm && $arch eq 'x86_64';
 
         eval {
             my $cmd_result = mon_cmd(
-- 
2.47.3




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* applied: [PATCH qemu-server] fix #7981: cpu flags: Hyper-V enlightenments on x86_64 only
  2026-08-31 10:17 [PATCH qemu-server] fix #7981: cpu flags: Hyper-V enlightenments on x86_64 only Erik Fastermann
@ 2026-09-03 13:32 ` Fiona Ebner
  0 siblings, 0 replies; 2+ messages in thread
From: Fiona Ebner @ 2026-09-03 13:32 UTC (permalink / raw)
  To: pve-devel, Erik Fastermann

On Mon, 31 Aug 2026 12:17:46 +0200, Erik Fastermann wrote:
> 'hv-passthrough' is x86-only, so QEMU's ARM target rejects it with
> "Parameter 'model.props.hv-passthrough' is unexpected". The whole
> expansion then fails, leaving pvestatd unable to populate the
> cpuflags-kvm node key on aarch64 hosts. Guard with the arch to prevent
> this.
> 
> Fixes: 698550c2 ("cpu flags: include Hyper-V enlightenment flags in supported flags")
> 
> [...]

Applied, thanks! I avoided the blank line between the Fixes and the
other trailers, for consistency with existing commits, and I slightly
changed the commit title to include 'query for'.

[1/1] fix #7981: cpu flags: query for Hyper-V enlightenments on x86_64 only
      commit: 6c0127e612f6c576888a13f9bfb30874911b804d




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-03 13:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-31 10:17 [PATCH qemu-server] fix #7981: cpu flags: Hyper-V enlightenments on x86_64 only Erik Fastermann
2026-09-03 13:32 ` applied: " Fiona Ebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal