public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH manager 0/2] api: ceph: mds: do not set unused keys in config file
@ 2026-07-15  8:24 Maximiliano Sandoval
  2026-07-15  8:24 ` [PATCH manager 1/2] api: ceph: mds: deprecate createmds' hotstandby parameter Maximiliano Sandoval
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Maximiliano Sandoval @ 2026-07-15  8:24 UTC (permalink / raw)
  To: pve-devel

See commits.

Maximiliano Sandoval (2):
  api: ceph: mds: deprecate createmds' hotstandby parameter
  api: ceph: mds: do not set unused keys in config file

 PVE/API2/Ceph/MDS.pm | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

-- 
2.47.3





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH manager 1/2] api: ceph: mds: deprecate createmds' hotstandby parameter
  2026-07-15  8:24 [PATCH manager 0/2] api: ceph: mds: do not set unused keys in config file Maximiliano Sandoval
@ 2026-07-15  8:24 ` Maximiliano Sandoval
  2026-07-15  8:24 ` [PATCH manager 2/2] api: ceph: mds: do not set unused keys in config file Maximiliano Sandoval
  2026-08-07 10:45 ` applied-series: [PATCH manager 0/2] " Fabian Grünbichler
  2 siblings, 0 replies; 4+ messages in thread
From: Maximiliano Sandoval @ 2026-07-15  8:24 UTC (permalink / raw)
  To: pve-devel

The configuration mds_standby_replay set by this parameter was removed for Ceph
14.1.1 in [1].

[1] https://github.com/ceph/ceph/commit/d4638836ba2335f5b8eeb4a7624992caf7bb6901

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 PVE/API2/Ceph/MDS.pm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/PVE/API2/Ceph/MDS.pm b/PVE/API2/Ceph/MDS.pm
index 31b6fb7e3..57a7f5e4d 100644
--- a/PVE/API2/Ceph/MDS.pm
+++ b/PVE/API2/Ceph/MDS.pm
@@ -151,8 +151,9 @@ __PACKAGE__->register_method({
                 optional => 1,
                 default => 0,
                 description =>
-                    "Determines whether a ceph-mds daemon should poll and replay the log of an active MDS. "
-                    . "Faster switch on MDS failure, but needs more idle resources.",
+                    "Determines whether a ceph-mds daemon should poll and replay the log of an active MDS."
+                    . " Faster switch on MDS failure, but needs more idle resources."
+                    . " Deprecated: the setting was removed in Ceph 14.1.1.",
             },
         },
     },
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH manager 2/2] api: ceph: mds: do not set unused keys in config file
  2026-07-15  8:24 [PATCH manager 0/2] api: ceph: mds: do not set unused keys in config file Maximiliano Sandoval
  2026-07-15  8:24 ` [PATCH manager 1/2] api: ceph: mds: deprecate createmds' hotstandby parameter Maximiliano Sandoval
@ 2026-07-15  8:24 ` Maximiliano Sandoval
  2026-08-07 10:45 ` applied-series: [PATCH manager 0/2] " Fabian Grünbichler
  2 siblings, 0 replies; 4+ messages in thread
From: Maximiliano Sandoval @ 2026-07-15  8:24 UTC (permalink / raw)
  To: pve-devel

... during MDS creation.

The configuration keys:
- mds_standby_for_name
- mds_standby_replay

Were removed for Ceph 14.1.1 in [1].

[1] https://github.com/ceph/ceph/commit/d4638836ba2335f5b8eeb4a7624992caf7bb6901

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 PVE/API2/Ceph/MDS.pm | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/PVE/API2/Ceph/MDS.pm b/PVE/API2/Ceph/MDS.pm
index 57a7f5e4d..1a5791151 100644
--- a/PVE/API2/Ceph/MDS.pm
+++ b/PVE/API2/Ceph/MDS.pm
@@ -195,11 +195,6 @@ __PACKAGE__->register_method({
             }
 
             $cfg->{$section}->{host} = $nodename;
-            $cfg->{$section}->{'mds_standby_for_name'} = 'pve';
-
-            if ($param->{hotstandby}) {
-                $cfg->{$section}->{'mds_standby_replay'} = 'true';
-            }
 
             cfs_write_file('ceph.conf', $cfg);
 
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* applied-series: [PATCH manager 0/2] api: ceph: mds: do not set unused keys in config file
  2026-07-15  8:24 [PATCH manager 0/2] api: ceph: mds: do not set unused keys in config file Maximiliano Sandoval
  2026-07-15  8:24 ` [PATCH manager 1/2] api: ceph: mds: deprecate createmds' hotstandby parameter Maximiliano Sandoval
  2026-07-15  8:24 ` [PATCH manager 2/2] api: ceph: mds: do not set unused keys in config file Maximiliano Sandoval
@ 2026-08-07 10:45 ` Fabian Grünbichler
  2 siblings, 0 replies; 4+ messages in thread
From: Fabian Grünbichler @ 2026-08-07 10:45 UTC (permalink / raw)
  To: pve-devel, Maximiliano Sandoval


On Wed, 15 Jul 2026 10:24:30 +0200, Maximiliano Sandoval wrote:
> See commits.
> 
> Maximiliano Sandoval (2):
>   api: ceph: mds: deprecate createmds' hotstandby parameter
>   api: ceph: mds: do not set unused keys in config file
> 
> PVE/API2/Ceph/MDS.pm | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> [...]

Applied, thanks!

[1/2] api: ceph: mds: deprecate createmds' hotstandby parameter
      commit: 6e1726a693496bc22e577b9e8049dc6945388286
[2/2] api: ceph: mds: do not set unused keys in config file
      commit: eec8cc17008ddf2c2645fde12327d8e93797b15c

Best regards,
-- 
Fabian Grünbichler <f.gruenbichler@proxmox.com>




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-08-07 10:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-15  8:24 [PATCH manager 0/2] api: ceph: mds: do not set unused keys in config file Maximiliano Sandoval
2026-07-15  8:24 ` [PATCH manager 1/2] api: ceph: mds: deprecate createmds' hotstandby parameter Maximiliano Sandoval
2026-07-15  8:24 ` [PATCH manager 2/2] api: ceph: mds: do not set unused keys in config file Maximiliano Sandoval
2026-08-07 10:45 ` applied-series: [PATCH manager 0/2] " Fabian Grünbichler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal