[PATCH storage] zfspool: export: fix regression with printing progress output

[PATCH storage] zfspool: export: fix regression with printing progress output

[Fiona Ebner]

The progress from zfs send is printed to stderr, but the lines are
passed from run_command() to errfunc() without a trailing newline in
and so they would not show up in the task log right away, even with
the following call to flush. Use chomp() for future-proofing (e.g. if
there were an $errmsg, run_command() would call errfunc() with a
newline) and attach an explicit newline for each line passed to the
errfunc() to fix the issue.

Fixes: e0eb405 ("zfspool: export: skip hardcoded warning about no-preserve-encryption flag")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/Storage/ZFSPoolPlugin.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/PVE/Storage/ZFSPoolPlugin.pm b/src/PVE/Storage/ZFSPoolPlugin.pm
index 8630744..4c5b6c5 100644
--- a/src/PVE/Storage/ZFSPoolPlugin.pm
+++ b/src/PVE/Storage/ZFSPoolPlugin.pm
@@ -868,7 +868,8 @@ sub volume_export {
         errfunc => sub {
             my $line = shift;
             if ($line !~ /^WARNING: no-preserve-encryption flag set, sending dataset/) {
-                print STDERR $line;
+                chomp($line);
+                print STDERR "$line\n";
                 *STDERR->flush();
             }
         },
-- 
2.47.3

applied: [PATCH storage] zfspool: export: fix regression with printing progress output

[Thomas Lamprecht]

On Thu, 23 Jul 2026 10:50:37 +0200, Fiona Ebner wrote:
> The progress from zfs send is printed to stderr, but the lines are
> passed from run_command() to errfunc() without a trailing newline in
> and so they would not show up in the task log right away, even with
> the following call to flush. Use chomp() for future-proofing (e.g. if
> there were an $errmsg, run_command() would call errfunc() with a
> newline) and attach an explicit newline for each line passed to the
> errfunc() to fix the issue.
> 
> [...]

Applied, thanks!

[1/1] zfspool: export: fix regression with printing progress output
      https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=22cea6404b13fded68afee146b9e60383ae8eb2d